Repository navigation
compat.fribidi: -fPIC on linux and macOS only; static entry points on windows - #577
Merged
Merged
Conversation
Sunrisepeak
added a commit
to Sunrisepeak/mui
that referenced
this pull request
Oct 26, 2026
fribidi is linked as a static library; under _WIN32 its headers declare dllimport entry points unless FRIBIDI_LIB_STATIC is defined. A platform-scoped define in the manifest (not in source); pairs with mcpplibs/mcpp-index#577.
Member
Author
Sunrisepeak
force-pushed
the
fribidi-no-fpic-msvc
branch
from
October 26, 2026 21:07
bc85990 to
fc194e5
Compare
… windows
clang rejects -fPIC for the MSVC target ("unsupported option '-fPIC' for
target 'x86_64-pc-windows-msvc'"), and PE/COFF has no such distinction. On
windows fribidi-common.h makes every entry point dllexport/dllimport unless
FRIBIDI_LIB_STATIC is defined; this package builds a static library, so it is.
Sunrisepeak
force-pushed
the
fribidi-no-fpic-msvc
branch
from
October 26, 2026 21:15
fc194e5 to
bd62e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #571, which gave compat.fribidi a windows build: under the MSVC ABI it does not compile.
-fPICmoves tolinux/macosxtables, as compat.gmp and compat.godot-cpp do: PE/COFF has no such distinction.FRIBIDI_LIB_STATIC: without itfribidi-common.hmarks every entry point__declspec(dllexport)(anddllimportfor consumers) under_WIN32, but this package is a static library. A consumer that includes the headers on windows defines it too (openmui's text engine does).