0.5.1 —— 模板的构建程序没跟着改 - #4
Merged
Merged
Conversation
0.5.0 改了两个 example 的 build.mcpp 和模板的 README,漏了 templates/three-machines/build.mcpp.in —— 它仍带 x86_64 的旧早退。于是 模板的 README 说 mcpp run --target x86_64-none-elf,而模板生成的工程在那台 机器上配不出 runner。两者互相矛盾。⚠️ CI 看不见,而原因和 0.4.0 那次同形:模板检查落在 gate 的 riscv64 一行, 而那一行只装 RISC-V 的模拟器 —— 它物理上只能断言「模板在 riscv64 上能跑」。 修法两条: - build.mcpp.in 自「The emulator」起与 examples/switch/build.mcpp 逐字节相同 - 「能跑」这一半改为逐行断言,每行断言自己装了模拟器的那台机器;「能为三台 机器构建」这一半仍在一行上,因为那是宿主无关的主张 实测:手工渲染模板后三台机器都打印 switch ok。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.5.0 把两个 example 的
build.mcpp和模板的 README 都改了,漏了模板自己的build.mcpp.in。它仍带 x86_64 的旧早退,于是:mcpp run --target x86_64-none-elf两者互相矛盾,而这是发布出去的快速上手。
模板检查落在
gate的 riscv64 一行,而那一行只装 RISC-V 的模拟器。它能支持的主张因此只有「模板在 riscv64 上能跑」,而模板的 README 已经开始主张三台。⭐ 0.4.0 的教训是「断言必须放在能观察到所要主张之现象的作业里」。0.5.0 把它执行到了作业一级,没执行到行一级。
修法
build.mcpp.in自「The emulator」起与examples/switch/build.mcpp逐字节相同(diff 为空)\$PWD重写在 Windows 上有已知的路径形态问题实测
手工渲染模板 → 三台机器
mcpp run全部打印switch ok。