Repository navigation
fix: preserve JIT symbols in precompiled runners - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve okrun's native JIT rendezvous symbols in the precompiled distribution. The original 0.5.0 Linux package passes execution smoke tests but is stripped, so a host debugger cannot find its JIT registration function or descriptor. Source-built runners retain those symbols and already pass source debugging.
Use the existing
mcpp pack --no-stripoption only for okrun. An optional validated asset-revision suffix provides new filenames without changing source tags or package versions. Preflight refuses existing asset names; uploading no longer uses clobber. Existing 0.5.0 assets remain unchanged.Before upload, all hosts retain their actual unpacked-program smoke checks. Linux x86-64 additionally checks both symbols in the just-unpacked runner, creates a small compressed-DWARF image with the selected LLVM toolchain, and requires GDB and LLDB to stop in source, read 40, step to 42 and exit normally. Other hosts' smoke checks do not claim native debugger qualification.
Validation: eight exact workflow filename/immutability controls and all shell-block syntax checks pass. The real original package fails the new symbol guard. A source runner only validates the fixture and debugger commands locally; it does not qualify the revised package. The corrective binary workflow 42161303189 passed all four native jobs at head
3848b37668412c3c9b32cb98c203e99dee182133. The freshly extracted Linux package passed both symbol checks and the actual GDB/LLDB source-step assertions; the uploaded artificial-fixture logs were read back. Source CI 42161307487 also passed all five checks. All 13 revised canonical GitCode assets and 12 per-tool CN copies passed actual download and SHA-256 verification against GitHub. No image implementation, API, dependency version or released tag changes.