Repository navigation
0.5.2 --- an image's main thread has a thread's stack on Windows - #32
Merged
Merged
Conversation
An image is entered on okrun's main thread, whose stack on Windows is the executable's reservation, the linker's 1 MiB; clangd.okb indexing the MSVC headers on its main thread ended in STATUS_STACK_OVERFLOW. okrun.exe now reserves 8 MiB + 256 KiB, a thread's default under openkal-windows. The stack example recurses through 6 MiB on the main thread on every system. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
lld-link on the MSVC ABI takes /STACK, the MinGW driver --stack. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An image is entered on okrun's main thread. On Windows that thread's stack is the executable's reservation, the linker's default 1 MiB (measured in the PE header of the released okrun.exe), while openkal-windows gives every other thread at least 8 MiB and Linux and macOS give the main thread 8 MiB. clangd.okb with
--syncindexes the MSVC headers on its main thread and ended inSTATUS_STACK_OVERFLOW(0xC00000FD) on windows-2022, where the native clangd passes (mcppls-clangd image e2e).tools/mcpp.toml: on Windows the tools link with--stack,8650752(8 MiB + 256 KiB, a thread's default and openkal-windows' guard slack).examples/stack: an image that recurses through 6 MiB of frames on its main thread; CI runs it on the four hosts.Verified locally: the cross-built okrun.exe reserves 8650752 bytes; under wine the stack image prints its line with the new okrun.exe and dies silently with the 0.5.1 one; okrun on Linux runs it.
Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com