chore: do not carry what is not the package - #2
Merged
Conversation
Two files were tracked that describe a machine rather than the package: one editor's settings, and a compilation database whose every entry is an absolute path on the machine that produced it. Neither is reproducible, neither is read by anything that builds this package, and both change whenever somebody opens the directory. The ignore list is now the same in all six repositories of this project, and it names what a build produces, what an editor leaves beside the sources, and what a file browser leaves behind. A repository that carries one editor's settings has an opinion about editors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files were tracked that describe a machine rather than the package:
openkal/.vscode/settings.jsonandopenkal-windows/compile_commands.json.Neither is reproducible, neither is read by anything that builds these packages,
and both change whenever somebody opens the directory.
The ignore list is now the same in all six repositories of this project, and it
names three kinds of thing rather than one:
target/,.mcpp/,mcpp.lock,compile_commands.json.vscode/,.idea/,.cache/,*.swp,*~.DS_Store,Thumbs.dbThe released tag is moved after this merges, so that the published tarball does
not carry them either — the index entry that would pin its
sha256has not beenopened yet.