Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
6ed85d6 to
3a6ebd1
Compare
This comment has been minimized.
This comment has been minimized.
Bump react-dropzone from 14.4.1 to 20.1.4 in file-uploader-web and rich-text-web. Regenerate the isExt patch for the new dist layout (dist/index.js, dist/index.cjs), since the upstream regex is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3a6ebd1 to
1ac6a13
Compare
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: Run code quality check, Plan E2E matrix, sigridci · unrelated failures: security/snyk (external scanner, "16 tests have failed"; the code and license Snyk checks pass) Findings
|
Pull request type
Dependency changes (any modification to dependencies in
package.json)Description
Updates
react-dropzonefrom 14.4.1 to 20.1.4 infile-uploader-webandrich-text-web. This also brings inattr-accept4.0.1 andfile-selector5.0.2, and dropsprop-types.The local patch
patches/react-dropzone.patch(stricterisExtextension check) is still needed, because 20.1.4 has the same regex. v16 removeddist/es/and the UMD build, so the patch now targetsdist/index.js,dist/index.cjsandsrc/utils/index.ts.Breaking changes from 15 to 20, checked against our code:
isDragRejectcleared after drop: no impact. Both widgets read it only together withisDragActive.file-selector5 still includes a default table that covers all of them, so files the browser leaves without a type are still accepted. Only a custom format with an uncommon MIME type and no extensions loses that fallback.multiple: false. When several images are dropped at once, the first one is now used; before, nothing happened. This is in the changelog. File Uploader sets no file limit, so it is not affected.Unit tests pass (File Uploader 137/137, Rich Text 605/605), lint has no errors, and both widgets build with the patched regex in the bundle.
What should be covered while testing?
SecurityErrorfromFileSystemFileHandle.getFilein the console. If possible, also try the new web-based Outlook.🤖 Generated with Claude Code