Repository navigation
Conversation
leonardomendix
approved these changes
Nov 9, 2026
gjulivan
approved these changes
Nov 13, 2026
Plotly.js 3.x bundles maplibre-gl 4.x (GHSA-jrc7-96c5-q579) and has no backport. 4.2.0 bundles maplibre-gl 6.11.2. - plotly.js-dist-min ^3 -> ^4.2.0 in all chart widgets and shared-charts - react-plotly.js ^2.6 -> ^4.1; drop @types/plotly.js-dist-min and @types/react-plotly.js (v4 ships its own types) - shared-charts: moduleResolution bundler to resolve react-plotly.js/factory - adapt to v4 types (PlotData and Annotations removed)
r0b1n
force-pushed
the
r0b1n/plotly-v4
branch
from
November 17, 2026 08:38
3bc3461 to
0c37d11
Compare
r0b1n
marked this pull request as ready for review
November 17, 2026 09:20
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: AI Code Review (this review) · unrelated failures: Questions
Positives
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plotly.js 3.x (latest 3.7.0) bundles
maplibre-gl4.7.1, which is affected by GHSA-jrc7-96c5-q579 (critical XSS in the attribution control, fixed in maplibre-gl 6.4.1). There's no 3.x backport; the fix shipped in plotly.js 4.1.1. 4.2.0 bundles maplibre-gl 6.11.2.pnpm auditalso flaggedprobe-image-sizethrough the same path; both are clean after this change.Only Custom Chart accepts arbitrary Plotly JSON (and so could reach map traces), but the vulnerable code is in every chart widget's bundle.
What
plotly.js-dist-min^3.0.0->^4.2.0in the 9 chart widgets andshared/chartsreact-plotly.js^2.6.0->^4.1.0@types/plotly.js-dist-minand@types/react-plotly.js(v4 packages ship their own types; the old@types/plotly.jsclashed with them)plotly.js@^4.2.0as ashared/chartsdevDependency so thereact-plotly.jspeer stops auto-resolving to 3.7.0 (it is never bundled;react-plotly.js/factoryis used)shared/chartsmoduleResolution: bundlersoreact-plotly.js/factoryresolvesPlotDataandAnnotationsno longer exist in v4;Layout["xaxis"]is now optional; a cast inCustomChartControllerHostStatus
tsc, unit tests and rollup builds pass for all chart widgets and chart-playgroundsecurity/snykcheck still fails and is being ignored for this PR.Breaking changes for Custom Chart users
Mapbox traces removed (use
scattermapetc.), stricter color parsing (fractionalrgb(),hsv()), Chart Studio config options removed,geo.fitbounds/splom.axis.matchesdefaults changed. Migration guide: https://plotly.com/javascript/guides/migrating-to-v4/Versioning (major bump for Custom Chart) is to be decided at release time.