Repository navigation
Conversation
… height Group content was animated by measuring it with getBoundingClientRect and writing an inline height, kept up to date by a debounced ResizeObserver. The height lagged behind content changes, so content was cut off for a few frames, and groups that load content when expanded opened empty and jumped. A group toggled while hidden (e.g. in an inactive tab) never got transitionend and stayed stuck at 0px. The group is now a grid whose content row transitions between 0fr and 1fr, so the browser sizes the content at all times. The content wrapper clips during the animation and is visibility: hidden when collapsed. The DOM and class names are unchanged, so Atlas and custom theme selectors still match. - transitionend only completes on the group's own grid-template-rows - a fallback timer completes the toggle when transitionend does not fire; with no transition (reduced motion, theme override) it completes at once - "load when expanded" content renders at the start of the expand - prefers-reduced-motion disables the transition - remove the ResizeObserver hook Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: code quality check, E2E matrix, sigridci, Snyk code · unrelated failures: security/snyk (external scanner; I did not inspect the log) Positives
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
Accordion group content was animated by measuring it with
getBoundingClientRectand writing an inlineheight, kept up to date by a debouncedResizeObserver. That caused several problems:transitionendand stayed stuck at0px.The group is now a CSS grid whose content row transitions between
0frand1fr, so the browser sizes the content at all times. The content wrapper clips during the animation and isvisibility: hiddenwhen collapsed. The DOM structure and class names are unchanged, so Atlas and custom theme selectors still match.transitionendonly completes the toggle for the group's owngrid-template-rowstransition (not bubbled child transitions)transitionenddoes not fire; with no transition (reduced motion, theme override) it completes immediatelyprefers-reduced-motiondisables the transitionResizeObserverhook is removedpnpm testpasses (73 tests);pnpm linthas no errors.What should be covered while testing?
🤖 Generated with Claude Code