Repository navigation
Conversation
will-change: opacity made every node body its own stacking context, so an open combobox menu was painted under the following node. Drop will-change and lift the body that contains an open popup ([data-overlay-content]), which also covers the short window while the opacity transition runs.
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: Run code quality check, Plan E2E matrix, sigridci · unrelated failures: security/snyk (external scanner) Positives
|
gjulivan
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
In Tree Node v2, a combo box placed in a node could open its menu underneath the next node, so part of the option list was hidden. Identically configured combo boxes behaved differently: a menu that stayed inside its own node, or had no node after it, looked fine, while a menu that reached into the next node was covered.
Cause:
.widget-tree-node-v2-bodyhadwill-change: grid-template-rows, opacity.will-change: opacitymakes every node body its own stacking context, even when nothing animates, so the menu'sz-indexonly competed inside its own node, and later nodes were painted over it.Fix:
will-change. It gave no real benefit:grid-template-rowscan't be composited, and theopacityhint only kept one extra layer per expandable node. Thetransitionstill drives the animation..widget-tree-node-v2-body:has([data-overlay-content]) { position: relative; z-index: 1 }. While the opacity transition runs (~200ms) the body is a stacking context again; this lifts the body containing an open popup above its siblings, at every nesting level. It's the same approach as the data grid header cells (.th:has([data-overlay-content])in_datagrid.scss).What should be covered while testing?