Repository navigation
chore(agents): add blast-radius skill, comment and testing rules, PR body structure - #2537
Merged
Merged
Conversation
…body structure - New blast-radius skill: find what a change breaks outside its diff (consumers, XML contract, themes, bundling modules, input/a11y) and prove the safety facts by running code against the change and its base. - AGENTS.md: Code Comments (explain why only) and Testing (behavior, not implementation) sections. - PR template: Why / What changed / Scope / Tradeoffs / Blast radius / Verification briefing sections; implementation-plan.md points to it instead of keeping a stale copy. - code-review skill: checks for comments, implementation-pinned tests and the new PR body sections.
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): none. This PR changes docs and agent skills only, with no package code. CI: pending: Plan E2E matrix, Read versions file, Run code quality check, sigridci · unrelated failures: security/snyk (dependency scan on a docs-only change) Positives
|
leonardomendix
approved these changes
Nov 17, 2026
yordan-st
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
No code changes (changes to documentation, CI, metadata, etc.)
Why
Agents (and people) working in this repo keep running into the same problems:
This PR is inspired by pstack, an MIT-licensed set of agent skills. I adapted a few of its ideas to our stack. This is a derived work, not a copy, so pstack is credited only here and not in the files themselves.
What changed
New
blast-radiusskill (.agents/skills/blast-radius/). It finds what a change could break outside its diff:It then proves the facts the change is safe because of by running code against both the change and its base.
AGENTS.mdgets two new sections:PR template: "Description" is replaced by the sections Why / What changed / Scope / Tradeoffs / Blast radius / Verification. Verification includes what used to be "What should be covered while testing?".
implementation-plan.mdnow points to the template instead of keeping a stale copy of it.code-reviewskill: flags narrating comments, commented-out code and suppressions without a reason, and tests pinned to the implementation. It asks about an empty Blast radius section when shared exports, XML or classes change.Scope
Agent docs and skills, plus the GitHub PR template. No package code.
Tradeoffs
.claude/rules/security.md.Blast radius
.githubandautomation).code-reviewskill runs in CI (ClaudeReview.yml). The new checks are Low severity, or Questions only, except a lint suppression on a correctness rule without a reason, which is Medium.Verification
I ran
blast-radiusblind on three pastwidget-plugin-gridchanges. Each agent checked out the old commit and couldn't see later history.2f2fbd49d(click classification). It caught thedetail === 0/ screen-reader regression that a later commit (68109637c) partly reverted, proven in Chromium. It missed the touch double-tap case. It also found a spec that flakes under turbo load, and a wrong OpenSpec scenario.78775eb33(pagination attribute sync). It found and proved 3 of the 6 issues fixed in the following days: attribute writes reverted onsetProps, the-1total-count placeholder written to the attribute, and a preset value overwritten at setup.692365a52(asetLimitguard, used as a control). It correctly judged the change safe and raised no false alarms.I folded what these runs taught us back into the skill: review the whole PR range, rerun every proof on the base, check per-package
Tests:lines, and the list of input, browser and attribute-sync checks.