Skip to content

chore(ci): remove the encodeurl@2.0.2 exclude from the site template trust policy - #13047

Merged
slorber merged 1 commit into
mainfrom
claude/encodeurl-latest-537225
Nov 13, 2026
Merged

slorber merged 1 commit into
mainfrom
claude/encodeurl-latest-537225

Conversation

@slorber

@slorber slorber commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

pillarjs/encodeurl#43 is closed: encodeurl@2.0.3 was re-released with npm trusted publishing (published by GitHub Actions, with provenance attestation), like the 3.x releases. pnpm's trustPolicy: no-downgrade no longer flags the 2.x line, so the encodeurl@2.0.2 entry added in #12947 can go.

The monorepo is unaffected: its lockfile pins encodeurl@2.0.0.

Test Plan

Reproduced the Supply Chain - Site Template job locally (without sfw): generated the classic TypeScript template from create-docusaurus@latest and @canary, then ran pnpm install with the job's pnpm-workspace.yaml, minus the encodeurl exclude.

  • Both installs pass and resolve encodeurl@2.0.3.
  • Control: overriding encodeurl to 2.0.2 still fails with High-risk trust downgrade for "encodeurl@2.0.2".

CI: the Supply Chain - Site Template jobs pass on this PR.

Test links

Deploy preview: https://deploy-preview-13047--docusaurus-2.netlify.app/

Related issues/PRs

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated supply-chain policy coverage for a package that was previously excluded. No user-facing functionality changed.

…trust policy

encodeurl@2.0.3 is published with npm trusted publishing.
See pillarjs/encodeurl#43

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@slorber
slorber requested a review from Josh-Cena as a code owner November 13, 2026 13:00
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 13, 2026
@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The security supply-chain workflow no longer excludes encodeurl@2.0.2 from pnpm’s trustPolicyExclude list.

Changes: Supply-chain policy

Layer / File(s) Summary
Trust policy update
.github/workflows/security-supply-chain.yml
The workflow removes the encodeurl@2.0.2 exception and its TODO comment from trustPolicyExclude.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 91abc

This change removes an obsolete supply-chain exclusion, so the trust policy is stricter again. If the exclusion were still needed, the Supply Chain - Site Template CI job would fail visibly. No merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change accurately: removing the encodeurl@2.0.2 exclusion from the site template trust policy. The raw summary confirms the only edit is in .github/workflows/security-supply-chain.…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change accurately: removing the encodeurl@2.0.2 exclusion from the site template trust policy. The raw summary confirms the only edit is in .github/workflows/security-supply-chain.yml, and the objectives describe the same exclusion removal. The title is specific and single-sentence. The 'chore(ci):' prefix is a conventional-commit type and does not affect the assessment.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 16b8fe96-9841-44d6-9aa1-63fc1bc5b026
Commits

Reviewing files that changed from the base of the PR and between 05200e2 and 91abce9.

Files selected for processing: 1

  • .github/workflows/security-supply-chain.yml
Files with no reviewable changes: 1

  • .github/workflows/security-supply-chain.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

@netlify

netlify Bot commented Nov 13, 2026

Copy link
Copy Markdown

✅ [V2]

Name Link
🔨 Latest commit 91abce9
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6af709d53fae69bafd0b90d1
😎 Deploy Preview https://deploy-preview-13047--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 58 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 52 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 71 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 71 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@slorber
slorber merged commit 7106067 into main Nov 13, 2026
22 checks passed
@slorber
slorber deleted the claude/encodeurl-latest-537225 branch November 13, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant