Fix GEMM tuner config restoration - #614
Open
Zhewen Tan (tandede) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gemm-config.hwhen tuning produces no valid candidateProblem
The tuner backs up
gemm-config.hbefore testing candidates, but each candidate overwrites the live file. When every candidate fails to build or parse,find_best_config()returns no result and the old flow exits normally without restoring the backup. This leaves the last failed candidate in place and also leaves the backup file behind.The same state could be retained when the user selected the best candidate but its final rebuild failed.
Validation
python -m pytest -q tests/test_tune_gemm_config.py(3 passed)python -m py_compile utils/tune_gemm_config.py tests/test_tune_gemm_config.pyruff check --select E9,F63,F7,F82 utils/tune_gemm_config.py tests/test_tune_gemm_config.py