Skip to content

Stop repeating rejected merge requests #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jake Bailey (jakebailey) merged 2 commits into from
Sep 3, 2026
Merged

Stop repeating rejected merge requests #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4cc0a
Add fixture for repeated merge rejection
jakebailey Sep 3, 2026
4855633
Stop repeating rejected merge requests
jakebailey Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/mergebot/src/_tests/fixtures/75097/derived.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
"lastPushDate": "2026-06-09T08:53:58.000Z",
"lastActivityDate": "2026-06-09T16:12:51.000Z",
"mergeOfferDate": "2026-06-09T16:54:12.000Z",
"mergeRequestDate": "2026-06-09T16:08:26.000Z",
"mergeRequestUser": "brandonbothell",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
Expand Down
45 changes: 0 additions & 45 deletions packages/mergebot/src/_tests/fixtures/75097/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,50 +71,5 @@
"id": "IC_kwDOAFz6BM8AAAABFeCnHw"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}",
"variables": {
"input": {
"id": "IC_kwDOAFz6BM8AAAABFdrr5w",
"body": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!\n<!--typescript_bot_wait-for-merge-offer-4e58a58-->"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}",
"variables": {
"input": {
"id": "IC_kwDOAFz6BM8AAAABFduBSg",
"body": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!\n<!--typescript_bot_wait-for-merge-offer-4e58a58-->"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}",
"variables": {
"input": {
"id": "IC_kwDOAFz6BM8AAAABFdwG-w",
"body": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!\n<!--typescript_bot_wait-for-merge-offer-4e58a58-->"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}",
"variables": {
"input": {
"id": "IC_kwDOAFz6BM8AAAABFdxfSg",
"body": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!\n<!--typescript_bot_wait-for-merge-offer-4e58a58-->"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}",
"variables": {
"input": {
"id": "IC_kwDOAFz6BM8AAAABFeCn7w",
"body": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!\n<!--typescript_bot_wait-for-merge-offer-4e58a58-->"
}
}
}
]
4 changes: 0 additions & 4 deletions packages/mergebot/src/_tests/fixtures/75097/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
{
"tag": "merge-offer",
"status": "@brandonbothell: Everything looks good here. I am ready to merge this PR (at 4e58a58) on your behalf whenever you think it's ready.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@dylhack, @k3rn31p4nic, @HanchaiN: you can do this too.)"
},
{
"tag": "wait-for-merge-offer-4e58a58",
"status": ":passport_control: Hi @brandonbothell,\n\nI can't [accept a pull request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until all of the checks in the \"Status\" section of [this comment](#issuecomment-4658093747) are green. I will let you know once that happens.\n\nThanks, and happy typing!"
}
],
"shouldClose": false,
Expand Down
3 changes: 3 additions & 0 deletions packages/mergebot/src/_tests/fixtures/75393/_downloads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mpv-script": 830
}
5 changes: 5 additions & 0 deletions packages/mergebot/src/_tests/fixtures/75393/_files.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"68eadaf30095e64f464c14185d4fe529efa1f6d8:types/mpv-script/.eslintrc.json": "{\n \"rules\": {\n \"@definitelytyped/no-single-element-tuple-type\": \"off\"\n }\n}\n",
"df17ec34853e80dac955a0c2649cec989d90b2b5:types/mpv-script/package.json": "{\n \"private\": true,\n \"name\": \"@types/mpv-script\",\n \"version\": \"0.32.9999\",\n \"nonNpm\": true,\n \"nonNpmDescription\": \"mpv-script\",\n \"projects\": [\n \"https://github.com/mpv-player/mpv\"\n ],\n \"devDependencies\": {\n \"@types/mpv-script\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"David T\",\n \"githubUsername\": \"mrxdst\"\n },\n {\n \"name\": \"sharpchen\",\n \"githubUsername\": \"sharpchen\"\n }\n ]\n}\n",
"68eadaf30095e64f464c14185d4fe529efa1f6d8:types/mpv-script/package.json": "{\n \"private\": true,\n \"name\": \"@types/mpv-script\",\n \"version\": \"0.32.9999\",\n \"nonNpm\": true,\n \"nonNpmDescription\": \"mpv-script\",\n \"projects\": [\n \"https://github.com/mpv-player/mpv\"\n ],\n \"devDependencies\": {\n \"@types/mpv-script\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"David T\",\n \"githubUsername\": \"mrxdst\"\n },\n {\n \"name\": \"sharpchen\",\n \"githubUsername\": \"sharpchen\"\n }\n ]\n}\n"
}
Loading
Loading