Repository navigation
Fixing Type Hints on is enabled/get varient - #78
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the synchronous and asynchronous FeatureManager typing updates.
No open issues 🎉
What changed in this PR
Fixes #62 by aligning synchronous and asynchronous FeatureManager type hints with supported runtime calls, without changing runtime behavior.
Changes:
- Updates
is_enabledandget_variantoverloads to support calls without a user identifier and with a positionalTargetingContext. - Adds mypy regression tests checking exact return types across both APIs, including custom keyword arguments.
- Documents the typing fix in the changelog.
| File | Description |
|---|---|
tests/test_typing.py |
Adds parameterized static typing checks for sync and async calls. |
featuremanagement/aio/_featuremanager.py |
Corrects async overloads and clarifies positional context documentation. |
featuremanagement/_featuremanager.py |
Applies matching overload and documentation changes to the sync API. |
CHANGELOG.md |
Records the typing corrections under unreleased bug fixes. |
Review effort: Balanced
Zhiyuan Liang (zhiyuanliang-ms)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #62
The method signature was never udpated for user_id support as a property.
Contribution checklist:
General Guidelines and Best Practices