Repository navigation
Fix SDK-qualified MCP permission matching - #62
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified that would require changes before approval.
No open issues 🎉
What changed in this PR
This follow-up to #61 fixes host permission matching for SDK-qualified MCP tool names while preserving server-specific allowlists and confidentiality-profile restrictions.
Changes:
- Accept both bare and server-qualified tool names for the matching GitHub or wiki-writer server.
- Explicitly deny managed approvals and managed-settings sessions, with distinct static denial messages.
- Add permission-matching and log-safety regressions, and document the contract. Public visibility enforcement remains unchanged.
| File | Description |
|---|---|
tests/test_host_telemetry.py |
Adds coverage for accepted name formats, cross-server denials, managed approvals, and log safety. |
main.py |
Fixes server-bound permission matching and explicitly rejects managed approvals. |
docs/guide.md |
Documents accepted tool-name formats and preserved permission restrictions. |
Review effort: Balanced
Changyong Gong (chagong)
deleted the
chagong-msrc-ticket-investigation
branch
November 10, 2026 01:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #61. SDK 1.0.29 supplies MCP permission requests with an already-qualified tool name, for example
server_name="github"andtool_name="github-get_repository". The host prefixed that name again and rejected the resultinggithub-github-get_repositoryidentity, blocking legitimate reads and team-memory operations.wiki-writerserver.Validation
git diff --checkpassed.Rollout
This PR changes repository code only. No Foundry deployment or production workflow rerun has been performed.