Improve dataset preload startup UX - #2457
Open
hannahwestra25 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hannahwestra25
marked this pull request as ready for review
August 21, 2026 19:02
| - name: scorer | ||
| - name: technique | ||
| - name: load_default_datasets | ||
| # Optional full preload/cache warming; scenarios fetch requested datasets on demand. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Optional full preload/cache warming; scenarios fetch requested datasets on demand. | |
| # Optional full preload/cache warming; scenarios fetch requested datasets on demand and add them to memory. |
| preload_message = "" | ||
| if "loading datasets" in log_tail.casefold(): | ||
| preload_message = ( | ||
| " Dataset preloading is still in progress. Remove load_default_datasets from the config " |
Contributor
There was a problem hiding this comment.
cp: Finding “loading datasets” in the recent log proves that preload occurred, but not necessarily that it is still running—the completed tqdm line can remain in the log while startup later hangs elsewhere. Consider wording this as “Dataset preloading was detected in the recent logs” or “may still be in progress” to avoid a misleading diagnosis.
Justin Song (jsong468)
approved these changes
Aug 21, 2026
| @@ -8,4 +8,5 @@ initializers: | |||
| - scorer | |||
| - name: scorer | |||
| - name: technique | |||
Contributor
There was a problem hiding this comment.
fine to remove, but we may want to modify the datasets the garak hallucination scenario uses by default so we can make the default run go faster. Fine to do in a followup
Richard Lundeen (rlundeen2)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LoadDefaultDatasetsbehavior and the default timeout are unchanged.