Repository navigation
memory: add opt-in Wiki relationship and Inbox review workflow - #3292
Merged
Hillary Mutisya (hillary-mutisya) merged 4 commits intoNov 19, 2026
Merged
Conversation
Keep related subjects independent, retain qualified new partial drafts, and reserve one evidence-bound Sol arbitration with durable Inbox review. Revalidate source access, citations, revisions and preservation before applying drafts; keep native model replacement separate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep draft-save complexity within the existing budget without changing quality semantics, and expose the focused Wiki browser fixture separately from unrelated browser qualification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve final factual audits alongside opt-in Wiki quality checks and keep partial drafts editable and readable without publication authority. Complete source-retirement protocol metadata, update MCP discovery coverage, and hash full paginated source content in retrieval fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hillary Mutisya (hillary-mutisya)
merged commit Nov 19, 2026
d4309b2
into
main
188 of 197 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Wiki candidates can be related without being duplicates, and useful draft material can be partially grounded without being safe to combine with or replace an existing article. Previously unresolved cases need a durable, evidence-bound review path rather than disappearing into construction failures or granting implicit merge authority.
This PR separates that shared workflow from changing the underlying decision model. It retains the existing configured Luna-backed decision path.
Behavior and configuration
FileMemoryServiceOptions.wikiReview: trueorTYPEAGENT_MEMORY_WIKI_REVIEW=truethrough configured memory hosts.GPT_6_1_SOL, one durable logical reservation per frozen evidence/revision set, bounded recorded transport retries, no alternate-model fallback or recursive semantic repair. Interrupted or unsuccessful calls remain reviewable.Reviewer guide
Validation
Local validation on Windows with Node 26.13.0. Full build, pinned formatting and all four committed whole-branch gates pass at 6fae4bf, which merges fetched main e6e2d50.
The merge preserves main's final informational factual-field audit alongside opt-in choice-only quality. Partial drafts remain editable/readable only under normal evidence checks; partial quality cannot bypass factual auditing, publication or indexing gates.
Current follow-up validation:
wikiAmbiguity,informationalRetrieval,sourceFollowing,evidenceWindowinformationalSupport,viewDrafts,viewStoreReview,filesystemPublicationtest:localmemoryMcpServer,viewInventoryProtocol,wikiAmbiguityProtocoldefault-agent-providercompiler step and offlinerecipeModelProvidersuiteThe final combined service run passed 16 suites / 356 tests on the pushed source, including the draft read/edit adjustment. It selects the eight service suites above plus
wikiConsolidation,wikiContribution,informationalWiki,viewSupport,viewEditorialTemporal,viewSeparationService,wikiPlanningRecoveryandschemaRequestAdmission. These counts overlap the smaller selections and must not be added together.The browser renderer (531 tests) and Chromium fixture (2 tests) also passed after merging main, before the final backend/protocol-only fixes.
Historical pre-merge validation
Full build, formatting and committed gates previously passed at 9c8e47d, against main 4f2d364.
The broad tests below passed on the initial implementation 8e1367f. Follow-up 34cc3fd extracts the unchanged draft-quality copy expression into a helper to stay within the complexity budget and gives the browser fixture its own test command. After that refactor, the five affected save/partial/restart suites passed 101/101. The policy bot's 9c8e47d only alphabetizes that package script key; it changes no executable source or test content. No prior result is being presented as a fresh full rerun.
ts:pnpm run buildpnpm run jest-esm --runInBand --runTestsByPathselectingwikiAmbiguity,viewSupport,wikiDecision,wikiAdmission,wikiPlanningRecovery,viewHostOptions,wikiConsolidation,wikiContribution,wikiGrouping,viewEditorial,informationalWiki,viewSeparationService,filesystemPublication,wikiConsolidationRecovery,wikiConsolidationTemporalcompiled specsviewStore,viewStoreReview,viewDrafts,wikiAmbiguity,viewSupportspecs,--runInBand --runTestsByPathpnpm run test:localwikiAmbiguityProtocol,consolidationProtocol,capabilitiesProtocol,viewInventoryProtocol,editorialProtocol,viewBuildProtocolspecspnpm run test:views:clientchromeRpcRouting,browserViewNavigation,indexJest suitesnode --test test/viewGateway.test.mjs test/viewDraftGateway.test.mjs test/viewLifecycle.test.mjs test/memoryHub.test.mjspnpm run test:views:wiki-review-browserpnpm run prettier:changedpnpm run code-lint -- --ratchet --base origin/mainpnpm run code-complexity -- --ratchet --base origin/main --cyclomatic 25 --cognitive 30 --new-file-cyclomatic 25 --new-file-cognitive 30pnpm run code-circular -- --ratchet --base origin/main --exceptions-file tools/scripts/code/circular-baseline-exception.jsonpnpm run code-debt -- --gate --base origin/mainUI verification: the real-browser fixture imports the production Inbox card renderer with synthetic evidence and checks complete evidence visibility, all three guarded actions, stale errors and refresh errors. The renderer suite separately mounts the Hub activity feed and verifies disabled read-only review behavior. Prerequisite: a compatible local Chromium (
TYPEAGENT_BROWSER_EXECUTABLE) or Puppeteer's pinned Chrome (pnpm exec puppeteer browsers install chrome). No recording, real-user payload, live model call or latency measurement was used.Risks, limitations and rollout
This is an opt-in initial release. Sol availability and model judgments remain operational/quality risks, so failed or unverifiable proposals stay visible and original pages are retained. The edit surface is structured JSON, not a visual merge editor.
Deterministic and browser verification do not establish live model accuracy, Sol cost or end-to-end readiness latency. This PR makes no performance claim, does not enable native Decision1 and does not qualify default enablement.
Current-head CI and review status
6fae4bf is pushed and GitHub reports the branch mergeable. It merges main and fixes the missing source-retirement protocol field, the advertised MCP tool inventory and the retrieval fixture's hash of a truncated source page. The fixture now reads all source-content pages rather than weakening source-hash validation.
The earlier workflow-approval gate was cleared and those runs exposed the now-reproduced regression failures. The original Azure Windows provider build diagnostic did not reproduce locally. Fresh Azure build 144591 now confirms the Windows full build and both platforms' smoke tests pass. No speculative API/export change was made.
Current-head CI is complete: 106 checks passed, 3 skipped, no failures or pending checks; all required checks passed. Skips are the two conditional macOS package-partition jobs and fork-only formatting.
Build-ts CI passed on attempt 2. One unchanged Windows Node 24 agent-session batching test initially observed two publications instead of one; its bounded admission window is 25 ms. All 15 tests in that suite passed locally, the Windows Node 26 shard passed, and one targeted retry of the affected Windows Node 24 shard passed. No assertion, timeout or production behavior was changed to obtain that result.
The paginated feedback inventory found no general comments, reviews, inline comments or review threads; no reviewers are currently requested. Monitoring has ended. Normal reviewer approval is still required; this PR has not been merged or automatically approved.