ci: enforce EditorConfig across repository - #18761
ci: enforce EditorConfig across repository#18761Tobias Brick (tobiasb-ms) wants to merge 2 commits into
Conversation
Check all tracked text files while excluding generated, legal, centrally managed, and byte-identical upstream artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The updated hook configuration should restrict to types: [text] to match the stated intent and avoid scanning binaries, and the PR description indicates existing violations are still outstanding.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s pre-commit linting configuration to enforce EditorConfig rules more broadly, while carving out documented exclusions for generated or externally managed content.
Changes:
- Expand
editorconfig-checkercoverage from only*.tomlto (intended) all tracked text files. - Add explicit, documented exclusions for generated specs and specific legal/centrally managed/upstream-artifact files.
File summaries
| File | Description |
|---|---|
| .pre-commit-config.yaml | Broadens EditorConfig checking scope and documents path-based exclusions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
.pipelines/CodeQL/CodeQL.yml is not valid YAML due to incorrect indentation under jobs:.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/12 changed files
- Comments generated: 3
- Review effort level: Lite
Clean the existing maintained-file baseline so repository-wide EditorConfig enforcement can pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0d22853 to
0fa6655
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent with the stated goal (repo-wide EditorConfig enforcement + cleanup) and are limited to formatting/regen artifacts without introducing behavioral modifications.
Review details
- Files reviewed: 5/16 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Summary
Validation
pre-commit run --all-files --show-diff-on-failure