fix: libmng - remove flagged files

[Andrew Phelps (anphel31)]

Remove the prebuilt Win32 DLL bcb/win32dll/libmng.dll from libmng.

It is a UPX-packed PE32 DLL shipped alongside upstream's Borland C++ Builder project files, and the package-signing scan rejects the .src.rpm because of it. Nothing in the build references it (bcb / win32dll appear in no *.am, *.ac, *.in or Makefile*), and it is not installed into any binary RPM.

• An azldev archive overlay (file-remove) drops the DLL and repacks the tarball; the post-overlay hash is pinned via origin = { type = "overlay" }.
• contrib/msvc/libmng-msvc.lib/libmng.lib is left in place - a plain ar import library rather than a packed executable, and out of scope here.

Base, devel, debuginfo and debugsource RPMs all build, and azldev comp render --check-only reports no drift.

[Copilot]

🟡 Changes recommended

The source hash is still a placeholder, and the lock and rendered outputs have not been regenerated.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes a prebuilt Windows DLL from libmng’s upstream archive.

Changes:

• Moves libmng into a dedicated component definition.
• Adds a metadata-backed file-remove overlay.
• Declares the repacked archive as an overlay-generated source.

File summaries

File	Description
base/comps/components.toml	Removes the inline libmng entry.
base/comps/libmng/libmng.comp.toml	Defines the customized component and repacked source.
base/comps/libmng/overlays/0001-remove-prebuilt-windows-dll.overlay.toml	Removes the DLL from the archive.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Andrew Phelps (anphel31)]

Local verification on 9c6c459 (per AGENTS.md minimum required testing):

Build — azldev comp build -p libmng produced libmng-2.0.3-28.azl4 base, devel, debuginfo and debugsource RPMs.

Overlay effect — the tarball embedded in the built SRPM is 315 members (was 316). bcb/win32dll/libmng.dll is gone; the sibling libmng.bpr / libmng.cpp Borland project text files are retained, as intended. Its SHA512 matches the pinned hash exactly.

Inspect — rpm -qlp across every subpackage shows no binary artifact is shipped. The only remaining dll match is the text doc /usr/share/doc/libmng/README.dll, confirming the DLL was never installed into a binary RPM.

Smoke test — mock chroot, compiled against libmng-devel and linked libmng.so.2:

header MNG_VERSION_TEXT=2.0.3
runtime mng_version_text()=2.0.3
mng_initialize OK
mng_reset OK
mng_cleanup OK
SMOKE_EXIT=0

pkg-config --modversion libmng -> 2.0.2. Library loads and the init/reset/cleanup lifecycle works, so removing the DLL had no effect on the built library.

Drift — render --check-only reports CHANGED=false and update --check-only exits 0, both re-run after committing.

[Copilot]

🟢 Approval recommended

The overlay, source pin, lock, and rendered outputs are consistent, and the prior findings are resolved.

Review details

• Files reviewed: 5/6 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[reuben olinsky (reubeno)]

/azp run

[azure-pipelines]

Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.