refactor(images): remove VM base image - #18776
Draft
binujp wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7bd3adef-a234-420d-b07f-e7301af0b050
As part of consolidating images to 1P and 3P variants for both Gen1 and Gen2 image types, drop the standalone vm-base image. vm-base was effectively the Gen2 1P x86_64 image and was the first image built in this repo, predating the current 1P/3P hierarchy. Now that the hierarchical image definitions and the rest of the 1P/3P Gen1/Gen2 images are in place, vm-base is redundant: 1p-vm-base-gen2 is a strict superset of vm-base, carrying 3 extra packages (rsyslog, libestr, libfastjson) on top of an otherwise identical package set. Retain the shared VmBaseCore profile for 1P images and move the UEFI static checks to the 1P Gen2 replacement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3188afea-d864-49af-acba-88a493e5b703
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new Python tests violate enforced Ruff S101 rules, and the README still documents the removed test directory.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the redundant vm-base image while retaining its shared package profile and replacing it with 1p-vm-base-gen2.
Changes:
- Moves Gen2 UEFI configuration into the 1P hierarchy.
- Registers the replacement image and transfers its test suites.
- Adds replacement-specific kernel and partition checks.
File summaries
| File | Description |
|---|---|
base/images/tests/README.md |
Updates VM test examples. |
base/images/tests/cases/static/1p-vm-base-gen2/test_partitions.py |
Adds partition checks. |
base/images/tests/cases/static/1p-vm-base-gen2/test_kernel.py |
Adds kernel checks. |
base/images/teams/cloud/vm-base.xml |
Retains only VmBaseCore. |
base/images/teams/cloud/onep.xml |
Defines the Gen2 UEFI profile. |
base/images/images.toml |
Replaces the image registration. |
Review details
- Files reviewed: 4/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Update the documented static test path and replace bare assertions with explicit pytest failures to satisfy Ruff S101. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f91d50d8-beef-4a67-a321-beba16e98506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm-baseimageVmBaseCoreprofile for 1P images1p-vm-base-gen2replacementRationale
vm-basepredates the current 1P/3P Gen1/Gen2 hierarchy and is superseded by1p-vm-base-gen2, which otherwise has the same package set plusrsyslog,libestr, andlibfastjson.