feat(images): require explicit per-image architectures - #18778
Draft
binujp wants to merge 1 commit into
Draft
Conversation
Remove the top-level default-image-architectures setting; every image now declares its own mandatory architectures list. Sync the vendored azldev schema to match the updated azldev implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3188afea-d864-49af-acba-88a493e5b703
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pinned azldev version rejects the newly added architectures keys as unknown fields.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Makes supported architectures explicit for every image and updates the vendored schema accordingly.
Changes:
- Declares architectures for all images.
- Restricts Gen1 images to
x86_64. - Requires
architecturesin the schema.
File summaries
| File | Description |
|---|---|
base/images/images.toml |
Adds per-image architecture lists. |
external/schemas/azldev.schema.json |
Requires the new image field. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [images.vm-base] | ||
| description = "VM Base Image" | ||
| definition = { type = "kiwi", path = "AzureLinux.kiwi", profile = "vm-base" } | ||
| architectures = ["x86_64", "aarch64"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Making architectures mandatory per image avoids implicit inheritance and makes each image definition self-contained.