Patch fluent-bit for CVE-2026-33630 [HIGH] - #18779
Draft
Sumit Jena (SumitJenaHCL) wants to merge 1 commit into
Draft
Patch fluent-bit for CVE-2026-33630 [HIGH]#18779Sumit Jena (SumitJenaHCL) wants to merge 1 commit into
Sumit Jena (SumitJenaHCL) wants to merge 1 commit into
Conversation
Signed-off-by: SumitJenaHCL <v-sumitjena@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
Buddy Build has passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
fluent-bit(lib/c-ares-1.33.1).channel->queries_by_qidandchannel->all_queries. Callingares_cancel()from inside a callback therefore freed the query, and the caller then freed it a second time.ares_array_tvs.ares__array_t), unifiedread_tcp_data()/read_udp_packets_fd()into a singleread_answers(), and added arequested_serverargument toares_send_query()that does not exist in 1.33.1. The upstream commit has therefore been backported in full and adapted, rather than applied verbatim.Change Log
SPECS/fluent-bit/CVE-2026-33630.patch, a full backport of upstream c-ares commitd823199b, adapted to the bundled 1.33.1 tree:ares_flush_requeue()— a single shared, iterative drain for the deferred requeue/endqueue list that every flush site now funnels through. It detaches each query from all lookup lists before invoking its callback (the CVE-2026-33630 fix), and re-dispatches retries by appending back onto the same list instead of recursing (upstream issue populate user's ssh/authorized_keys #1043).ares__send_query()split into a public wrapper that owns a requeue list and drains it, plusares__send_query_int()which defers retries and end-queries onto the caller's list. The wrapper re-checksqueries_by_qidbefore reporting success, since a deferred retry may have terminally failed and freed the query during the drain.process_timeouts()and both read paths now defer through the shared drain.read_udp_packets_fd()previously ignoredentry.typeand re-sentREQUEUE_ENDQUERYentries instead of completing them; routing it throughares_flush_requeue()corrects that as well.end_query()also detaches on its remaining inline path, which is still reachable viaares__requeue_query()fromares__close_connection().test/ares-test-mock.cc:MockUDPChannelTest.CancelInCallbackNoDoubleFreeandMockRetryDepthChannelTest.HighRetryNoStackOverflow.SPECS/fluent-bit/fluent-bit.spec: addedPatch14, incrementedRelease6 → 7, added a changelog entry.Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology