Repository navigation
fix: client bugs found by the upstream test ports - #2063
Open
Yury Semikhatsky (yury-s) wants to merge 5 commits into
Open
Yury Semikhatsky (yury-s) wants to merge 5 commits into
Yury Semikhatsky (yury-s) wants to merge 5 commits into
Conversation
- skip a route handler that another handler removed - a null header value in route.resume() and route.fallback() deletes the header - route.fulfill() marks the route as handled after the options are validated - Request.timing().responseStart of a response without one is responseEnd - page.video() is null when the context does not record video - storageState(path) writes indented JSON - APIRequestContext.dispose() of a disposed context does not throw - typed arrays in evaluate() results - the pseudo option of hasCSS - subscribe to console events of a worker - selectOption() rejects a null item - response.finished() of a request without a page - an empty string with a JSON content type is stringified
The call reports the error of the driver, and the route is marked as handled when the call succeeds, as in the Node.js client. The call returns without an error when the page closes first.
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
I don't see a point in updating the old code before it gets deleted. The Python migration never attempted to pass the new tests with the old implementation:
- old impl passed old tests
- new impl passed both old and new tests
Dmitry Gozman (dgozman)
approved these changes
Nov 19, 2026
|
|
||
| // java: pumps the connection until the reply arrives; when the page closes first the call returns | ||
| // without an error, as safeRace() of the target closed scope does upstream. | ||
| private void raceWithTargetClose(String method, Object params) { |
Contributor
There was a problem hiding this comment.
I think you'll need a more generic solution for the line-by-line port later on.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Fixme("java: ...")for: route handler removed by another handler, null header values inroute.resume()/route.fallback(),page.video()withoutrecordVideo, typed arrays inevaluate()results, thepseudooption ofhasCSS, console events of a worker, and others (see the first commit)route.abort(),route.resume()androute.fulfill()wait for the reply of the driver and report its error, as in the Node.js client@Fixmemarks of the tests that pass now