[rush-daemon][WS2.6][5/9] Match Rush exit semantics - #5966
Merged
Mo Jazayeri (mojaza) merged 5 commits intoAug 27, 2026
Merged
Conversation
Mo Jazayeri (mojaza)
force-pushed
the
mojazayeri-microsoft-rushd-ws2-exit-semantics-upstream
branch
from
August 26, 2026 17:15
5c4e0ca to
3ef60d4
Compare
Mo Jazayeri (mojaza)
marked this pull request as ready for review
August 26, 2026 17:42
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in Rush-compatible final outcomes and exit-code handling for daemon-routed phased and global commands.
Changes:
- Introduces typed command-result protocol contracts.
- Adds phased warning, failure, abort, and global exit-code policies.
- Ensures final results follow drained output, with expanded tests and documentation.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
libraries/rush-daemon/src/CommandResultPolicy.ts |
Implements result and exit-code policy. |
libraries/rush-daemon/src/GlobalCommandRequestClient.ts |
Adds final-result delivery. |
libraries/rush-daemon/src/GlobalCommandRequestRouter.ts |
Translates global execution outcomes. |
libraries/rush-daemon/src/PhasedRequestClient.ts |
Adds phased final-result delivery. |
libraries/rush-daemon/src/PhasedRequestRouter.ts |
Produces phased command outcomes. |
libraries/rush-daemon/src/index.ts |
Exports the global execution result. |
libraries/rush-daemon/src/test/CommandResultPolicy.test.ts |
Tests exit-semantic parity. |
libraries/rush-daemon/src/test/GlobalCommandRequestRouter.test.ts |
Tests global result handling. |
libraries/rush-daemon/src/test/PhasedRequestRouter.test.ts |
Tests phased outcomes and ordering. |
libraries/rush-daemon/src/test/PhasedRequestRouterTestUtilities.ts |
Supports result assertions. |
libraries/rush-daemon/README.md |
Documents result semantics. |
libraries/rush-daemon-protocol/src/DaemonCommandResult.ts |
Defines the shared result contract. |
libraries/rush-daemon-protocol/src/DaemonPhasedRequest.ts |
Adds environment and result fields. |
libraries/rush-daemon-protocol/src/index.ts |
Exports command-result types. |
libraries/rush-daemon-protocol/README.md |
Documents the protocol addition. |
common/reviews/api/rush-daemon.api.md |
Updates daemon API records. |
common/reviews/api/rush-daemon-protocol.api.md |
Updates protocol API records. |
common/changes/@rushstack/rush-daemon/mojazayeri-exit-semantics_2026-08-21-19-36.json |
Records the daemon change. |
common/changes/@rushstack/rush-daemon-protocol/mojazayeri-command-results_2026-08-21-19-36.json |
Records the protocol change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Base automatically changed from
mojazayeri-microsoft-rushd-ws2-global-context-upstream
to
main
August 26, 2026 20:21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mo Jazayeri (mojaza)
force-pushed
the
mojazayeri-microsoft-rushd-ws2-exit-semantics-upstream
branch
from
August 26, 2026 21:02
6cc9262 to
353a0dc
Compare
Sean Larkin (TheLarkInn)
approved these changes
Aug 27, 2026
Mo Jazayeri (mojaza)
deleted the
mojazayeri-microsoft-rushd-ws2-exit-semantics-upstream
branch
August 27, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates WS2 layer 5/9 into
microsoft/rushstackas a dependent draft that adds authoritative Rush-compatible command outcomes and exit-code translation for opt-in rushd phased and global routing.Depends on #5964. Supersedes mojaza#5. Follows #5949 and references #5897 without closing it. PBI: https://onedrive.visualstudio.com/EFun/_workitems/edit/3216022
Draft for explicit human review; do not merge without maintainer approval.
Details
RUSH_ALLOW_WARNINGS_IN_SUCCESSFUL_BUILDwithout mutatingprocess.env.Limitations
This remains opt-in and does not integrate the standalone daemon into
apps/rushor the normal Rush launcher. It does not add stdin/raw-mode/PTY fallback, scheduler command classification or wait/no-wait admission, concurrent shared-build merging, daemon lifecycle/restart, or CLI routing/configuration. Existing action construction and full command parsing remain integration-owned at the open #5895 boundary.How it was tested
rush build --only @rushstack/rush-daemon-protocol --only @rushstack/rush-daemon --verbose@rushstack/rush-daemon-protocol: 7 Jest suites, 37 tests passed@rushstack/rush-daemon: 10 Jest suites, 88 tests passedcommon/reviews/api/rush-daemon-protocol.api.mdandcommon/reviews/api/rush-daemon.api.mdas up to date