[rush-daemon][WS2.9][8/9] Merge shared builds - #5972
Merged
Mo Jazayeri (mojaza) merged 4 commits intoAug 28, 2026
Merged
Conversation
Mo Jazayeri (mojaza)
marked this pull request as ready for review
August 27, 2026 18:36
Mo Jazayeri (mojaza)
marked this pull request as draft
August 27, 2026 18:37
Mo Jazayeri (mojaza)
marked this pull request as ready for review
August 27, 2026 18:39
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shared-build batching to the warm Rush daemon graph while preserving request-scoped events, results, admission, and cancellation behavior.
Changes:
- Merges compatible phased build requests into one graph iteration.
- Adds per-client event multiplexing, result isolation, and cancellation handling.
- Expands integration and batching test coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
libraries/rush-daemon/src/PhasedRequestRouter.ts |
Coordinates merged graph iterations and client-scoped results. |
libraries/rush-daemon/src/PhasedRequestEventSink.ts |
Reports client output failures to the coordinator. |
libraries/rush-daemon/src/PhasedRequestEventMultiplexer.ts |
Fans graph events out to multiple request sinks. |
libraries/rush-daemon/src/test/PhasedRequestBatching.test.ts |
Tests batching, isolation, cancellation, and recovery. |
libraries/rush-daemon/src/test/RequestAdmissionIntegration.test.ts |
Tests admission timing and exclusive FIFO gating. |
libraries/rush-daemon/src/test/PhasedRequestRouterTestUtilities.ts |
Supports distinct test session identifiers. |
libraries/rush-daemon/README.md |
Documents shared-build batching behavior. |
common/changes/@rushstack/rush-daemon/mojazayeri-shared-build-merging_2026-08-22-00-11.json |
Records the minor package change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mo Jazayeri (mojaza)
marked this pull request as draft
August 27, 2026 20:43
Mo Jazayeri (mojaza)
marked this pull request as ready for review
August 27, 2026 20:44
Mo Jazayeri (mojaza)
force-pushed
the
mojazayeri-microsoft-rushd-ws2-shared-build-merge-upstream
branch
from
August 27, 2026 20:45
2822147 to
bf45a97
Compare
Base automatically changed from
mojazayeri-microsoft-rushd-ws2-8-request-admission-upstream
to
main
August 27, 2026 23:33
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mo Jazayeri (mojaza)
force-pushed
the
mojazayeri-microsoft-rushd-ws2-shared-build-merge-upstream
branch
from
August 27, 2026 23:33
bf45a97 to
d5c531c
Compare
Sean Larkin (TheLarkInn)
approved these changes
Aug 27, 2026
Bharat Middha (bmiddha)
approved these changes
Aug 27, 2026
Mo Jazayeri (mojaza)
deleted the
mojazayeri-microsoft-rushd-ws2-shared-build-merge-upstream
branch
August 28, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates WS2 layer 8/9 into
microsoft/rushstackas a dependent draft that merges compatible concurrent phasedSHARED-BUILDrequests into one warm operation-graph iteration while preserving client-scoped output and results.Depends on #5970. Supersedes mojaza#8. Follows merged #5949 and references #5897 without closing it. PBI: https://onedrive.visualstudio.com/EFun/_workitems/edit/3216025
Draft for explicit human review; do not merge without maintainer approval. Do not enable auto-merge.
Details
setEnabledStates/schedule/execute cycle.Limitations
This remains opt-in and dead-code-safe. It uses the existing injected real graph/shape seam and does not integrate with
apps/rushor constructPhasedScriptAction. Command-independent graph/plugin construction and complete per-iteration runner lifetime remain blocked by open #5895. It does not add WS3 lifecycle or WS4 CLI/config integration.How it was tested
node common/scripts/install-run-rush.js build --only @rushstack/rush-daemon --verbosenode common/scripts/install-run-rush.js change --verifygit diff --check, source-to-replay range-diff, and conflict-focused read-only review