Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/python-lro-typeddict-response-2026-09-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-python"
---

Return long-running operation response bodies when generating TypedDict-only models.
Original file line number Diff line number Diff line change
Expand Up @@ -1843,7 +1843,7 @@ def get_long_running_output(self, builder: LROOperationType) -> list[str]:
if builder.lro_response.headers:
retval.append(" response_headers = {}")
if (
(not self.code_model.options["models-mode"] and not self.code_model.generate_typeddict_only)
not self.code_model.options["models-mode"]
or self.code_model.options["models-mode"] == "dpg"
or builder.lro_response.headers
):
Expand Down
40 changes: 40 additions & 0 deletions packages/http-client-python/tests/unit/test_lro_response.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# -------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for
# license information.
# --------------------------------------------------------------------------

from types import SimpleNamespace

import pytest

from pygen.codegen.serializers.builder_serializer import LROOperationSerializer


@pytest.fixture(scope="session", autouse=True)
def testserver():
yield


class _TestLROOperationSerializer(LROOperationSerializer):
def response_headers_and_deserialization(self, builder, response):
return ["deserialized = response.json()"]


@pytest.mark.parametrize("models_mode", [None, "dpg"])
@pytest.mark.parametrize("generate_typeddict_only", [False, True])
def test_lro_response_is_available_for_deserialization(models_mode, generate_typeddict_only):
code_model = SimpleNamespace(
options={"models-mode": models_mode},
generate_typeddict_only=generate_typeddict_only,
get_serialize_namespace=lambda *args, **kwargs: "test",
)
serializer = _TestLROOperationSerializer(code_model, async_mode=False, client_namespace="test")
operation = SimpleNamespace(
lro_response=SimpleNamespace(headers=[], type=object()),
)

generated = serializer.get_long_running_output(operation)

assert " response = pipeline_response.http_response" in generated
assert " deserialized = response.json()" in generated
Comment thread
l0lawrence marked this conversation as resolved.
Resolved
Loading