Repository navigation
[http-client-python] Bundle playground dependency wheels without Pyodide CDN access - #12590
Closed
Libba Lawrence (l0lawrence) wants to merge 6 commits into
Closed
Libba Lawrence (l0lawrence) wants to merge 6 commits into
Libba Lawrence (l0lawrence) wants to merge 6 commits into
Conversation
… access Reapply microsoft#12484 (reverted in microsoft#12577). The playground build now reads pyodide-lock.json from the pinned pyodide npm dependency and resolves PyYAML/MarkupSafe via metadata-only placeholder wheels, so it never contacts cdn.jsdelivr.net, which the isolated release pipeline blocks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
|
You can try these changes here
|
Bundle all Pyodide dependency wheels, including PyYAML and MarkupSafe wasm builds, so the playground build performs no package downloads in the network-isolated release pipeline and the browser loads every package from emitter assets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace checked-in wheels with hash-pinned feed artifacts and build pure-Python PyYAML and MarkupSafe for the browser. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #12484 (reverted in #12577) with a fix for the release pipeline failure.
Root cause
ADO run 7073634 failed in Build emitter for playground bundle.
build_browser_wheels()downloaded Pyodide metadata and the PyYAML/MarkupSafe wasm wheels fromcdn.jsdelivr.net. The 1ES network-isolation proxy rejected that host with403 Tunnel connection failed. The playground step runs beforePublishNpm, so it also blocked npm publishing.Fix
pyodide-lock.jsonfrom the pinned Pyodide npm package, installed using the configured Azure SDK for JS feed.pip --require-hashesand the lock ineng/playground-requirements.txt. No dependency wheel binaries are checked into the current tree.setup.cfgmetadata without its optional native extension.The earlier draft commit containing wheel binaries remains in the branch history, but the current tree and PR diff remove them.
Validation
npm run build:playgroundsucceeded with package caching disabled behind a proxy that blockscdn.jsdelivr.net; the proxy observed only the Azure package feed and its storage hosts. The manifest contains 14 wheels, including pure-Python PyYAML and MarkupSafe.