Repository navigation
[WIP] Fix LastContractView to restore previous names of unknown discriminator models #12601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jorge Rangel (jorgerangel-msft)
wants to merge
10
commits into
main
Choose a base branch
from
copilot/lastcontractview-restore-previous-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+207
−0
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2b47b77
Initial plan
jorgerangel-msft ee8c212
fix(http-client-csharp): preserve unknown discriminator names from la…
jorgerangel-msft 1bd69cc
fix(http-client-csharp): guard restored names against synthesized types
jorgerangel-msft e026916
fix(http-client-csharp): close historical name collision guard gaps
jorgerangel-msft ef8efab
fix(http-client-csharp): reserve paging names across compatibility views
jorgerangel-msft c0e1570
fix(http-client-csharp): resolve historical unknown names independent…
jorgerangel-msft 6c015a0
refactor(http-client-csharp): keep unknown-name changes focused
jorgerangel-msft 0a55074
fix(http-client-csharp): resolve unknown names in BuildName
jorgerangel-msft 25dde1f
refactor(http-client-csharp): simplify unknown model name restoration
jorgerangel-msft 00f28e8
refactor(http-client-csharp): move proxy naming to SCM model provider
jorgerangel-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...ions/TestData/DiscriminatorTests/HistoricalUnknownNameRestoredPerHierarchyLevel/Models.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.ClientModel.Primitives; | ||
|
|
||
| namespace Sample.Models | ||
| { | ||
| [PersistableModelProxy(typeof(UnknownActivity))] | ||
| public abstract class PipelineActivity { } | ||
|
|
||
| [PersistableModelProxy(typeof(UnknownCopySource))] | ||
| public abstract class CopyActivitySource : PipelineActivity { } | ||
|
|
||
| internal class UnknownActivity : PipelineActivity { } | ||
|
|
||
| internal class UnknownCopySource : CopyActivitySource { } | ||
| } |
10 changes: 10 additions & 0 deletions
10
...ta/DiscriminatorTests/HistoricalUnknownNameUsedBySerialization(Public)/UnknownActivity.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Microsoft.TypeSpec.Generator.Customizations; | ||
|
|
||
| namespace Sample.Models | ||
| { | ||
| [CodeGenType("UnknownPipelineActivity")] | ||
| public partial class UnknownActivity { } | ||
| } |
1 change: 1 addition & 0 deletions
1
...onTypeDefinitions/TestData/DiscriminatorTests/HistoricalUnknownNameUsedBySerialization.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [global::System.ClientModel.Primitives.PersistableModelProxyAttribute(typeof(global::Sample.Models.UnknownActivity))] |
12 changes: 12 additions & 0 deletions
12
...efinitions/TestData/DiscriminatorTests/HistoricalUnknownNameUsedBySerialization/Models.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.ClientModel.Primitives; | ||
|
|
||
| namespace Sample.Models | ||
| { | ||
| [PersistableModelProxy(typeof(UnknownActivity))] | ||
| public abstract class PipelineActivity { } | ||
|
|
||
| internal class UnknownActivity : PipelineActivity { } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.