Skip to content

Generate ClientCore HTTP operations directly in the Java emitter - #12621

Open
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
microsoft:mainfrom
alzimmermsft:alzimmermsft-direct-clientcore-java-generation
Open

Alan Zimmer (alzimmermsft) wants to merge 4 commits into
microsoft:mainfrom
alzimmermsft:alzimmermsft-direct-clientcore-java-generation

Conversation

@alzimmermsft

Copy link
Copy Markdown
Member

Summary

  • Emit HTTP operation implementations directly for generic and azurev2 clients using the existing ClientCore pipeline. Fresh generated POMs no longer configure the ClientCore annotation processor.
  • Keep Azure v1/Fluent, public SDK metadata, and the explicit use-rest-proxy: true path unchanged.
  • Regenerate the ClientCore fixtures for all 67 TypeSpec scenarios and remove the processor configuration from their test POM.

Validation

  • Java emitter build and lint, Java Prettier/Spotless, and root pnpm format passed. The generator build ran 865 tests successfully.
  • Fresh generic and azurev2 clients compiled with -proc:none and executed root and operation-group calls over a fake HTTP transport.
  • Generate.ps1 passed, including the Todo and PetStore smoke builds. The regenerated ClientCore Spector suite ran with -Dmaven.compiler.proc=none: 364 passed, 44 skipped.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @typespec/http-client-java
Show changes

@typespec/http-client-java - feature ✏️

Generate HTTP operations directly for the generic and azurev2 Java clients, so newly generated SDKs no longer require the ClientCore annotation processor.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The feature changelog entry is missing the required illustrative code block showing how to compile a newly generated client with annotation processing disabled.

1 open issue
What changed in this PR

This PR moves HTTP operation generation into the Java emitter for generic and azurev2 clients, removing their dependency on ClientCore annotation processing while retaining the existing HTTP pipeline.

Changes:

  • Generate direct operation implementations and adjust proxy construction and imports.
  • Remove annotation-processor configuration from generated POMs and the ClientCore test project.
  • Regenerate client fixtures and document the new generation behavior.

Paths below are relative to packages/http-client-java/generator/, except .chronus/.

File Description
README.md Documents direct generation and the RestProxy option.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​template/​ServiceClientTemplate.java Adds imports for direct root-client operations.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​template/​ProxyTemplate.java Selects direct implementations or runtime RestProxy.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​template/​MethodGroupTemplate.java Adds imports for direct operation-group implementations.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​template/​clientcore/​ClientCorePomTemplate.java Removes processor setup and corrects plugin nesting.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​template/​azurevnext/​AzureVNextPomTemplate.java Removes processor setup and corrects plugin nesting.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​model/​clientmodel/​ServiceClient.java Omits unused RestProxy imports in direct mode.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​model/​clientmodel/​ProxyMethodParameter.java Omits HTTP annotation imports in direct mode.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​model/​clientmodel/​ProxyMethod.java Imports types needed by direct implementations.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​model/​clientmodel/​Proxy.java Adjusts annotation and RestProxy imports by mode.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​model/​clientmodel/​MethodGroupClient.java Omits RestProxy imports in direct mode.
http-client-generator-core/​src/​main/​java/​com/​microsoft/​typespec/​http/​client/​generator/​core/​extension/​plugin/​JavaSettings.java Adds the direct-generation mode predicate.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​typechangedfrom/​implementation/​TypeChangedFromClientImpl.java Regenerates type-change operations with direct HTTP calls.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​returntypechangedfrom/​implementation/​ReturnTypeChangedFromClientImpl.java Regenerates return-type-change operations.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​renamedfrom/​implementation/​RenamedFromClientImpl.java Regenerates renamed root operations.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​renamedfrom/​implementation/​NewInterfacesImpl.java Regenerates renamed interface operations.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​madeoptional/​implementation/​MadeOptionalClientImpl.java Regenerates optionality-versioning operations.
http-client-generator-clientcore-test/​src/​main/​java/​versioning/​added/​implementation/​InterfaceV2sImpl.java Regenerates added-interface operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​union/​discriminated/​implementation/​NoEnvelopeDefaultsImpl.java Regenerates unenveloped union operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​union/​discriminated/​implementation/​EnvelopeObjectDefaultsImpl.java Regenerates enveloped union operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​scalar/​implementation/​UnknownsImpl.java Regenerates unknown-scalar operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​scalar/​implementation/​StringOperationsImpl.java Regenerates string-scalar operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​scalar/​implementation/​BooleanOperationsImpl.java Regenerates boolean-scalar operations.
http-client-generator-clientcore-test/​src/​main/​java/​type/​array/​implementation/​StringValuesImpl.java Regenerates string-array operations.
http-client-generator-clientcore-test/​src/​main/​java/​streaming/​sse/​implementation/​UnnamedsImpl.java Regenerates unnamed event-stream operations.
http-client-generator-clientcore-test/​src/​main/​java/​streaming/​sse/​implementation/​RetrievesImpl.java Regenerates event-stream retrieval operations.
http-client-generator-clientcore-test/​src/​main/​java/​streaming/​sse/​implementation/​ProtocolDatasImpl.java Regenerates protocol event-stream operations.
http-client-generator-clientcore-test/​src/​main/​java/​streaming/​sse/​implementation/​NamedsImpl.java Regenerates named event-stream operations.
http-client-generator-clientcore-test/​src/​main/​java/​streaming/​jsonl/​implementation/​BasicsImpl.java Regenerates JSON Lines send and receive operations.
http-client-generator-clientcore-test/​src/​main/​java/​specialwords/​implementation/​ReservedOperationBodyParamsImpl.java Regenerates reserved-name body operations.
http-client-generator-clientcore-test/​src/​main/​java/​specialwords/​implementation/​ExtensibleStringsImpl.java Regenerates extensible-string operations.
http-client-generator-clientcore-test/​src/​main/​java/​specialheaders/​repeatability/​implementation/​RepeatabilityClientImpl.java Emits repeatability headers in direct requests.
http-client-generator-clientcore-test/​src/​main/​java/​server/​path/​single/​implementation/​SingleClientImpl.java Regenerates single-server-path operations.
http-client-generator-clientcore-test/​src/​main/​java/​server/​path/​multiple/​implementation/​MultipleClientImpl.java Regenerates parameterized server-path operations.
http-client-generator-clientcore-test/​src/​main/​java/​server/​endpoint/​notdefined/​implementation/​NotDefinedClientImpl.java Regenerates default-endpoint operations.
http-client-generator-clientcore-test/​src/​main/​java/​routes/​implementation/​RoutesClientImpl.java Regenerates fixed root routes.
http-client-generator-clientcore-test/​src/​main/​java/​routes/​implementation/​PathParametersReservedExpansionsImpl.java Emits reserved-expansion routes directly.
http-client-generator-clientcore-test/​src/​main/​java/​routes/​implementation/​PathParametersImpl.java Emits escaped path parameters directly.
http-client-generator-clientcore-test/​src/​main/​java/​routes/​implementation/​InInterfacesImpl.java Regenerates interface-scoped routes.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​xml/​implementation/​XmlErrorValuesImpl.java Emits XML response decoding and error mappings.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​multipart/​implementation/​FormDataHttpPartsNonStringsImpl.java Regenerates non-string multipart operations.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​multipart/​implementation/​FormDataHttpPartsImpl.java Regenerates complex multipart operations.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​head/​implementation/​HeadClientImpl.java Regenerates HEAD response handling.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​contentnegotiation/​implementation/​SameBodiesImpl.java Regenerates binary content-negotiation operations.
http-client-generator-clientcore-test/​src/​main/​java/​payload/​contentnegotiation/​implementation/​DifferentBodiesImpl.java Regenerates binary and JSON response operations.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​query/​implementation/​SpecialCharsImpl.java Emits special-character query names directly.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​query/​implementation/​ConstantsImpl.java Emits constant query parameters directly.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​path/​implementation/​PathClientImpl.java Regenerates required and optional path operations.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​collectionformat/​implementation/​HeadersImpl.java Emits collection-format request headers directly.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​bodyroot/​implementation/​BodyRootClientImpl.java Regenerates nested body-root operations.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​bodyoptionality/​implementation/​OptionalExplicitsImpl.java Emits optional request-body handling.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​bodyoptionality/​implementation/​BodyOptionalityClientImpl.java Regenerates required request-body operations.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​basic/​implementation/​ImplicitBodiesImpl.java Regenerates implicit-body operations.
http-client-generator-clientcore-test/​src/​main/​java/​parameters/​basic/​implementation/​ExplicitBodiesImpl.java Regenerates explicit-body operations.
http-client-generator-clientcore-test/​src/​main/​java/​encode/​duration/​implementation/​LossiesImpl.java Emits encoded duration query parameters directly.
http-client-generator-clientcore-test/​src/​main/​java/​documentation/​implementation/​TextFormattingsImpl.java Regenerates documentation scenario operations.
http-client-generator-clientcore-test/​src/​main/​java/​authentication/​union/​implementation/​UnionClientImpl.java Regenerates alternative-authentication operations.
http-client-generator-clientcore-test/​src/​main/​java/​authentication/​oauth2/​implementation/​OAuth2ClientImpl.java Regenerates OAuth2 operations and error mappings.
http-client-generator-clientcore-test/​src/​main/​java/​authentication/​noauth/​union/​implementation/​UnionClientImpl.java Regenerates optional-authentication operations.
http-client-generator-clientcore-test/​src/​main/​java/​authentication/​http/​custom/​implementation/​CustomClientImpl.java Regenerates custom-authentication operations and errors.
http-client-generator-clientcore-test/​src/​main/​java/​authentication/​apikey/​implementation/​ApiKeyClientImpl.java Regenerates API-key operations and error mappings.
http-client-generator-clientcore-test/​pom.xml Removes the test annotation-processor configuration.
.chronus/​changes/​java-generate-clientcore-http-operations.md Adds the Java emitter feature changelog entry.

Review effort: Balanced

- "@typespec/http-client-java"
---

Generate HTTP operations directly for the `generic` and `azurev2` Java clients, so newly generated SDKs no longer require the ClientCore annotation processor.
@azure-sdk-automation

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:java Issue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants