Repository navigation
Generate ClientCore HTTP operations directly in the Java emitter - #12621
Open
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Open
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The feature changelog entry is missing the required illustrative code block showing how to compile a newly generated client with annotation processing disabled.
1 open issue
What changed in this PR
This PR moves HTTP operation generation into the Java emitter for generic and azurev2 clients, removing their dependency on ClientCore annotation processing while retaining the existing HTTP pipeline.
Changes:
- Generate direct operation implementations and adjust proxy construction and imports.
- Remove annotation-processor configuration from generated POMs and the ClientCore test project.
- Regenerate client fixtures and document the new generation behavior.
Paths below are relative to packages/http-client-java/generator/, except .chronus/.
| File | Description |
|---|---|
README.md |
Documents direct generation and the RestProxy option. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/template/ServiceClientTemplate.java |
Adds imports for direct root-client operations. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/template/ProxyTemplate.java |
Selects direct implementations or runtime RestProxy. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/template/MethodGroupTemplate.java |
Adds imports for direct operation-group implementations. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/template/clientcore/ClientCorePomTemplate.java |
Removes processor setup and corrects plugin nesting. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/template/azurevnext/AzureVNextPomTemplate.java |
Removes processor setup and corrects plugin nesting. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ServiceClient.java |
Omits unused RestProxy imports in direct mode. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ProxyMethodParameter.java |
Omits HTTP annotation imports in direct mode. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ProxyMethod.java |
Imports types needed by direct implementations. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/Proxy.java |
Adjusts annotation and RestProxy imports by mode. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/MethodGroupClient.java |
Omits RestProxy imports in direct mode. |
http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/extension/plugin/JavaSettings.java |
Adds the direct-generation mode predicate. |
http-client-generator-clientcore-test/src/main/java/versioning/typechangedfrom/implementation/TypeChangedFromClientImpl.java |
Regenerates type-change operations with direct HTTP calls. |
http-client-generator-clientcore-test/src/main/java/versioning/returntypechangedfrom/implementation/ReturnTypeChangedFromClientImpl.java |
Regenerates return-type-change operations. |
http-client-generator-clientcore-test/src/main/java/versioning/renamedfrom/implementation/RenamedFromClientImpl.java |
Regenerates renamed root operations. |
http-client-generator-clientcore-test/src/main/java/versioning/renamedfrom/implementation/NewInterfacesImpl.java |
Regenerates renamed interface operations. |
http-client-generator-clientcore-test/src/main/java/versioning/madeoptional/implementation/MadeOptionalClientImpl.java |
Regenerates optionality-versioning operations. |
http-client-generator-clientcore-test/src/main/java/versioning/added/implementation/InterfaceV2sImpl.java |
Regenerates added-interface operations. |
http-client-generator-clientcore-test/src/main/java/type/union/discriminated/implementation/NoEnvelopeDefaultsImpl.java |
Regenerates unenveloped union operations. |
http-client-generator-clientcore-test/src/main/java/type/union/discriminated/implementation/EnvelopeObjectDefaultsImpl.java |
Regenerates enveloped union operations. |
http-client-generator-clientcore-test/src/main/java/type/scalar/implementation/UnknownsImpl.java |
Regenerates unknown-scalar operations. |
http-client-generator-clientcore-test/src/main/java/type/scalar/implementation/StringOperationsImpl.java |
Regenerates string-scalar operations. |
http-client-generator-clientcore-test/src/main/java/type/scalar/implementation/BooleanOperationsImpl.java |
Regenerates boolean-scalar operations. |
http-client-generator-clientcore-test/src/main/java/type/array/implementation/StringValuesImpl.java |
Regenerates string-array operations. |
http-client-generator-clientcore-test/src/main/java/streaming/sse/implementation/UnnamedsImpl.java |
Regenerates unnamed event-stream operations. |
http-client-generator-clientcore-test/src/main/java/streaming/sse/implementation/RetrievesImpl.java |
Regenerates event-stream retrieval operations. |
http-client-generator-clientcore-test/src/main/java/streaming/sse/implementation/ProtocolDatasImpl.java |
Regenerates protocol event-stream operations. |
http-client-generator-clientcore-test/src/main/java/streaming/sse/implementation/NamedsImpl.java |
Regenerates named event-stream operations. |
http-client-generator-clientcore-test/src/main/java/streaming/jsonl/implementation/BasicsImpl.java |
Regenerates JSON Lines send and receive operations. |
http-client-generator-clientcore-test/src/main/java/specialwords/implementation/ReservedOperationBodyParamsImpl.java |
Regenerates reserved-name body operations. |
http-client-generator-clientcore-test/src/main/java/specialwords/implementation/ExtensibleStringsImpl.java |
Regenerates extensible-string operations. |
http-client-generator-clientcore-test/src/main/java/specialheaders/repeatability/implementation/RepeatabilityClientImpl.java |
Emits repeatability headers in direct requests. |
http-client-generator-clientcore-test/src/main/java/server/path/single/implementation/SingleClientImpl.java |
Regenerates single-server-path operations. |
http-client-generator-clientcore-test/src/main/java/server/path/multiple/implementation/MultipleClientImpl.java |
Regenerates parameterized server-path operations. |
http-client-generator-clientcore-test/src/main/java/server/endpoint/notdefined/implementation/NotDefinedClientImpl.java |
Regenerates default-endpoint operations. |
http-client-generator-clientcore-test/src/main/java/routes/implementation/RoutesClientImpl.java |
Regenerates fixed root routes. |
http-client-generator-clientcore-test/src/main/java/routes/implementation/PathParametersReservedExpansionsImpl.java |
Emits reserved-expansion routes directly. |
http-client-generator-clientcore-test/src/main/java/routes/implementation/PathParametersImpl.java |
Emits escaped path parameters directly. |
http-client-generator-clientcore-test/src/main/java/routes/implementation/InInterfacesImpl.java |
Regenerates interface-scoped routes. |
http-client-generator-clientcore-test/src/main/java/payload/xml/implementation/XmlErrorValuesImpl.java |
Emits XML response decoding and error mappings. |
http-client-generator-clientcore-test/src/main/java/payload/multipart/implementation/FormDataHttpPartsNonStringsImpl.java |
Regenerates non-string multipart operations. |
http-client-generator-clientcore-test/src/main/java/payload/multipart/implementation/FormDataHttpPartsImpl.java |
Regenerates complex multipart operations. |
http-client-generator-clientcore-test/src/main/java/payload/head/implementation/HeadClientImpl.java |
Regenerates HEAD response handling. |
http-client-generator-clientcore-test/src/main/java/payload/contentnegotiation/implementation/SameBodiesImpl.java |
Regenerates binary content-negotiation operations. |
http-client-generator-clientcore-test/src/main/java/payload/contentnegotiation/implementation/DifferentBodiesImpl.java |
Regenerates binary and JSON response operations. |
http-client-generator-clientcore-test/src/main/java/parameters/query/implementation/SpecialCharsImpl.java |
Emits special-character query names directly. |
http-client-generator-clientcore-test/src/main/java/parameters/query/implementation/ConstantsImpl.java |
Emits constant query parameters directly. |
http-client-generator-clientcore-test/src/main/java/parameters/path/implementation/PathClientImpl.java |
Regenerates required and optional path operations. |
http-client-generator-clientcore-test/src/main/java/parameters/collectionformat/implementation/HeadersImpl.java |
Emits collection-format request headers directly. |
http-client-generator-clientcore-test/src/main/java/parameters/bodyroot/implementation/BodyRootClientImpl.java |
Regenerates nested body-root operations. |
http-client-generator-clientcore-test/src/main/java/parameters/bodyoptionality/implementation/OptionalExplicitsImpl.java |
Emits optional request-body handling. |
http-client-generator-clientcore-test/src/main/java/parameters/bodyoptionality/implementation/BodyOptionalityClientImpl.java |
Regenerates required request-body operations. |
http-client-generator-clientcore-test/src/main/java/parameters/basic/implementation/ImplicitBodiesImpl.java |
Regenerates implicit-body operations. |
http-client-generator-clientcore-test/src/main/java/parameters/basic/implementation/ExplicitBodiesImpl.java |
Regenerates explicit-body operations. |
http-client-generator-clientcore-test/src/main/java/encode/duration/implementation/LossiesImpl.java |
Emits encoded duration query parameters directly. |
http-client-generator-clientcore-test/src/main/java/documentation/implementation/TextFormattingsImpl.java |
Regenerates documentation scenario operations. |
http-client-generator-clientcore-test/src/main/java/authentication/union/implementation/UnionClientImpl.java |
Regenerates alternative-authentication operations. |
http-client-generator-clientcore-test/src/main/java/authentication/oauth2/implementation/OAuth2ClientImpl.java |
Regenerates OAuth2 operations and error mappings. |
http-client-generator-clientcore-test/src/main/java/authentication/noauth/union/implementation/UnionClientImpl.java |
Regenerates optional-authentication operations. |
http-client-generator-clientcore-test/src/main/java/authentication/http/custom/implementation/CustomClientImpl.java |
Regenerates custom-authentication operations and errors. |
http-client-generator-clientcore-test/src/main/java/authentication/apikey/implementation/ApiKeyClientImpl.java |
Regenerates API-key operations and error mappings. |
http-client-generator-clientcore-test/pom.xml |
Removes the test annotation-processor configuration. |
.chronus/changes/java-generate-clientcore-http-operations.md |
Adds the Java emitter feature changelog entry. |
Review effort: Balanced
| - "@typespec/http-client-java" | ||
| --- | ||
|
|
||
| Generate HTTP operations directly for the `generic` and `azurev2` Java clients, so newly generated SDKs no longer require the ClientCore annotation processor. |
|
You can try these changes here
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
genericandazurev2clients using the existing ClientCore pipeline. Fresh generated POMs no longer configure the ClientCore annotation processor.use-rest-proxy: truepath unchanged.Validation
pnpm formatpassed. The generator build ran 865 tests successfully.genericandazurev2clients compiled with-proc:noneand executed root and operation-group calls over a fake HTTP transport.Generate.ps1passed, including the Todo and PetStore smoke builds. The regenerated ClientCore Spector suite ran with-Dmaven.compiler.proc=none: 364 passed, 44 skipped.