[Eduardo Villalpando Mello (edvilme)]

Summary

• Characterize restart ordering, busy/ready and failure outcomes, including in-flight retry coalescing and timer cancellation.
• Verify late-result cleanup, deactivation ordering, and formatter ownership across asynchronous replacements and stale client events.
• Keep production behavior unchanged; track existing formatter lifecycle gaps separately in [Lifecycle] Formatter placeholder can be re-registered after disposal #138 and [Lifecycle] Investigate missing formatter fallback during replacement #139.

Closes #137.

Validation

Windows ARM64, Node 24.17.0:

• Targeted lifecycle tests: 39 passing.
• Full TypeScript suite: 152 passing.
• TypeScript build and source lint pass; changed test files also pass ESLint (pre-existing warnings only).
• git diff --check passes. Two in-memory regression probes confirm the strengthened retry and creation-failure assertions.
• The existing format-check still reports 14 unchanged production-source files, as noted in [S3] Characterize TypeScript client lifecycle boundaries #137. Both changed test files also fail a direct Prettier check on the baseline.

[Copilot]

🟢 Approval recommended

No active review issues block the lifecycle characterization tests, and existing formatter gaps are tracked separately in #138 and #139.

No open issues 🎉

What changed in this PR

Adds deterministic characterization tests for TypeScript client lifecycle boundaries, completing S3 (#137) without changing production behavior. Existing formatter lifecycle gaps remain tracked separately in #138 and #139.

Changes:

• Strengthens restart ordering, busy/ready status, and creation/start/trace failure assertions.
• Covers overlapping restart requests, retry coalescing, package-change debounce, and disposal cancellation.
• Verifies late-result cleanup, deactivation ordering, and formatter ownership across replacements and stale client events.

File	Description
typescript/​tests/​server.test.ts	Tests asynchronous restart ordering, status transitions, failure cleanup, and listener disposal.
typescript/​tests/​activation.test.ts	Tests retry and debounce timing, context disposal, deactivation ordering, and formatter lifecycle boundaries.

_{Review effort: Balanced}

[Rich Chiodo (rchiodo)]

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

[Rich Chiodo (rchiodo)]

Reviewed commit: 0f854d883e99591281137a5a508d547f6e573927

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running.

Test runs: none recorded.

[Rich Chiodo (rchiodo)]

Approved via Review Center.