Repository navigation
fix: restore formatter fallback during server replacement - #144
Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit intoNov 12, 2026
Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit into
Eduardo Villalpando Mello (edvilme) merged 1 commit into
Conversation
Restore the fallback after the old client's stop settles and before replacement startup, without registering beside a healthy old client. Preserve disposal guards and cover stop errors, failed startup, and stale client events with real restart orchestration and deferred barriers. Fixes #139 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Nov 12, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
Eduardo Villalpando Mello (edvilme)
added
the
debt
Eduardo Villalpando Mello (edvilme)
merged commit Nov 12, 2026
459caa5
into
main
18 of 20 checks passed
Eduardo Villalpando Mello (edvilme)
deleted the
fix/formatter-fallback-during-restart
branch
November 12, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139.
Summary
Restore the formatter fallback after the old client's stop settles and while replacement startup is pending, without adding it while the old client is still healthy.
onOldClientStoppednotification torestartServer, called before replacement creation only when the old client isStoppedafter its stop attempt settles.createToolContext+restartServerorchestration, the shared client mock, and explicit deferred stop/start barriers. No shared mock changes.The supported languageclient 8.1.0 implementation emits public
Stoppedwhen shutdown begins, before disposing feature registrations. Waiting for stop to settle avoids relying on that premature state event or keeping stale client/status listeners alive.Validation
Runtime: Node 24.17.0 / npm 11.13.0.
git diff --check: passed.Live VS Code formatter-picker behavior was not verified in an extension host. These tests establish lifecycle/provider ownership, not visible picker behavior.