Repository navigation
Adopt source-only internal build identities - #147
Conversation
Use vscode-python-tool-internal for local metadata, document pinned-source consumption, and remove versioned changelog conventions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the source-only runtime consumption changes.
No open issues 🎉
1 file not reviewed
typescript/package-lock.json: Generated file
What changed in this PR
Adopts source-only consumption for the shared Python and TypeScript runtimes, replacing obsolete package identities with internal build metadata while preserving public APIs and existing version values.
Changes:
- Documents pinned-checkout builds, dependency bundling, and consumer migration steps.
- Updates Python diagnostic version lookup to the internal distribution, with regression coverage for fallback and injected-server behavior.
- Removes the versioned changelog and obsolete label configuration, moving upgrade notes to PR descriptions and migration documentation.
| File | Description |
|---|---|
typescript/README.md |
Explains source-relative consumption of the built public entry. |
typescript/package.json |
Uses the internal build identity while remaining private. |
typescript/package-lock.json |
Aligns root package metadata with the internal identity. |
README.md |
Documents source-only build, installation, bundling, and migration requirements. |
python/vscode_common_python_lsp/server.py |
Looks up diagnostic versions using only the internal distribution. |
python/tests/test_server.py |
Covers internal metadata lookup, fallback, and injected-server behavior. |
python/README.md |
Clarifies local installation and the unchanged import namespace. |
python/pyproject.toml |
Sets the internal distribution name and private classifier. |
CONTRIBUTING.md |
Clarifies build identities and consumer-facing change documentation. |
CHANGELOG.md |
Removes the versioned changelog. |
.github/workflows/pr-labels.yml |
Removes no-changelog from accepted PR labels. |
.github/dependabot.yml |
Stops applying the obsolete no-changelog label. |
Review effort: Balanced
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
vscode-python-tool-internalsolely for local build/install metadata. npm remains private; Python carriesPrivate :: Do Not Upload. Keep existing version values and do not add publication or version synchronization.v0.0.0-devfallback and injected-server behavior, with regression coverage.no-changeloglabel configuration. Use PR descriptions for consumer-facing change/upgrade notes and focused migration documentation for breaking changes.Compatibility and adoption
The Python import namespace
vscode_common_python_lsp, TypeScript public exports, settings payloads/defaults and tool lifecycle behavior are unchanged. Repository URLs and submodule paths retain their existing names.Existing consumers must remove the former shared npm dependency/alias, update imports to the built source entry, regenerate their lockfiles and ensure their bundler includes the runtime dependency closure. The README documents build order and packaging requirements. Python consumers continue local-path installation and must bundle their reviewed runtime dependencies and the new distribution metadata.
This PR does not migrate consumer repositories or add source-provenance enforcement. Pending typed-definition examples and deferred provenance tooling must remain aligned with these source-consumption instructions when integrated. The diagnostic metadata version is not a source-revision identity.
Validation
vscode-python-tool-internalmetadata lookup and default server version verified. Package build/install ran offline after temporary build prerequisites were installed.git diff --checkpassed.Closes #146.