Repository navigation
Add typed tool definitions and settings - #148
Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit intoNov 13, 2026
Merged
Conversation
Add opt-in settings contracts and generic resolver return types without changing runtime behavior. Preserve legacy callers and document source-relative adoption. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Nov 13, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
Eduardo Villalpando Mello (edvilme)
added
the
debt
Eduardo Villalpando Mello (edvilme)
merged commit Nov 13, 2026
a1bff32
into
main
18 of 20 checks passed
Eduardo Villalpando Mello (edvilme)
deleted the
refactor/s5-typed-definitions
branch
November 13, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolDefinition<TSettings>andToolSettings<TSettings>contracts, including support for ordinary interfaces and compatible common settings.ToolConfigAPI.trackedSettingsunchanged.Rebased onto current
main; documentation uses the built public entry point from a pinned checkout, not a registry package identity.Validation
Using Node 24.17.0:
npm run buildnpm test -- --reporter dot: 161 passing, including compilation of the type-check fixtures duringpretest.npm run lint: passes with two existing warnings.git diff --checkNative consuming-extension builds and live VS Code UI integration were not exercised. This is an additive compile-time contract, not runtime schema validation or a consumer migration.
Closes #145