Repository navigation
Update dependencies to address security advisories - #14850
Sean McManus (sean-mcmanus) wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
MSAL 7 is forced outside Azure Identity’s declared dependency ranges, and authenticated publishing was not validated against live Azure sign-in.
No open issues 🎉
3 files not reviewed
.github/actions/package-lock.json: Generated fileExtensionPack/package-lock.json: Generated fileThemes/package-lock.json: Generated file
What changed in this PR
Updates dependencies across Actions and extension packaging to address security advisories without changing application code.
Changes:
- Updates vulnerable transitive dependencies and raises
serialize-javascriptto 7.1.3. - Pins
@azure/msal-nodeto 7.1.1 across the three extension packages. - Upgrades Actions Mocha to 12.0.3, removing its
bracesdependency; the Extension’s existingbracesdependency remains.
| File | Description |
|---|---|
Themes/package.json |
Adds the patched MSAL override. |
Themes/package-lock.json |
Locks updated MSAL and qs dependencies. |
ExtensionPack/package.json |
Adds the patched MSAL override. |
ExtensionPack/package-lock.json |
Locks updated MSAL dependencies. |
Extension/yarn.lock |
Locks updated MSAL, qs, and serialization dependencies. |
Extension/package.json |
Adds the MSAL pin and raises the serialization resolution. |
.github/actions/package.json |
Upgrades Mocha and the serialization override. |
.github/actions/package-lock.json |
Records security updates and Mocha’s revised dependency tree. |
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
The major authentication upgrades affect publishing credentials, but live Azure sign-in and Marketplace publishing still require human validation.
No open issues 🎉
3 files not reviewed
.github/actions/package-lock.json: Generated fileExtensionPack/package-lock.json: Generated fileThemes/package-lock.json: Generated file
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The minimum VS Code version change needs a changelog entry explaining that users on versions 1.77–1.81 must upgrade to continue receiving fixes.
1 open issue
3 files not reviewed
.github/actions/package-lock.json: Generated fileExtensionPack/package-lock.json: Generated fileThemes/package-lock.json: Generated file
Review effort: Balanced
| "license": "SEE LICENSE IN LICENSE.txt", | ||
| "engines": { | ||
| "vscode": "^1.77.0" | ||
| "vscode": "^1.82.0" |

Summary
follow-redirectsto 1.16.2, addressing GHSA-mrwp-f3q8-3g9p, and update vulnerableundici,ip-address, andqsdependencies.mochadev dependency, eliminating itsbracesandglobdependency paths.@azure/identity4.14.1 and@azure/msal-node7.1.1, addressing GHSA-xcx6-jx8p-x3h5 without overriding incompatible dependency ranges.serialize-javascriptto 7.1.3, which fixes GHSA-m5mm-p8h7-m29v. The Extension still usesbraces3.0.3, for which no fixed release is available.minimatchremains affected by GHSA-g3hv-75wg-m249 in the Actions, Extension, Extension Pack, and Themes dependency trees. The first patched major version is outside several current parent dependency ranges.Validation
follow-redirects1.16.2.