Repository navigation
Use internal package feeds with authenticated ci:msft - #1144
Bill Schnurr (bschnurr) wants to merge 5 commits into
Conversation
Match flake8/environments: pass Pylance_PublicPackages as the custom npm registry, use npm ci instead of the proxy-forcing ci:msft helper, and let PipAuthenticate supply Python feed credentials without per-step proxy overrides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Preserve the release variable names and ci:msft command. Honor the effective npm registry for lockfile rewriting and installation while inheriting the template-authenticated npmrc. Resolve PIP_PROXY_INDEX_URL from PipAuthenticate output so per-step pip settings retain feed credentials. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace packagefeedproxy defaults with Pylance_PublicPackages for npm and DevDiv/debugpy for pip. Preserve public defaults and update existing setup/registry tests. No workflow or credential changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ensure slashless npm registry overrides end in a slash before building lockfile download URLs and invoking npm ci. Add regressions for public/internal registry rewrites and both uppercase/lowercase environment overrides while preserving npm authentication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
|
||
| env: | ||
| PIP_INDEX_URL: https://packagefeedproxy.microsoft.io/pypi/simple/ | ||
| PIP_INDEX_URL: https://pkgs.dev.azure.com/devdiv/DevDiv/_packaging/debugpy/pypi/simple/ |
There was a problem hiding this comment.
Issue · Please address or respond
📍 .github/workflows/pr-check.yml:9
High: The Skeptic reproduced HTTP 401 responses and failed pip resolution against this index, but this workflow and push-check.yml:14 provide no feed authentication before installing Python dependencies on fresh GitHub-hosted runners. Configure supported authentication before the first installation, and retain an accessible feed path for fork PRs where credentials cannot be supplied.
[verified]
Summary
Use internal Microsoft package feeds while preserving the original Azure release caller structure:
build/package-feeds.json: Microsoft npm defaults tohttps://devdiv.pkgs.visualstudio.com/DevDiv/_packaging/Pylance_PublicPackages/npm/registry/; Microsoft pip defaults tohttps://pkgs.dev.azure.com/devdiv/DevDiv/_packaging/debugpy/pypi/simple/. Public defaults are unchanged.NPM_CONFIG_REGISTRY,PIP_PROXY_INDEX_URL,npm run ci:msft, andcustomNPMRegistry: $(NPM_CONFIG_REGISTRY).PIP_PROXY_INDEX_URLreferences$(PIP_INDEX_URL)provided by the template'sPipAuthenticate@1, so the existing per-step environment mappings retain credentials rather than substituting an unauthenticated URL.ci:msfthonorsnpm_config_registry/NPM_CONFIG_REGISTRYfor lockfile rewriting and installation. With no override, it now uses the internal JSON default. Its npm child inheritsNPM_CONFIG_USERCONFIGand credentials unchanged; Azure'snpmAuthenticate@0still obtains the credentials.No secrets were created, changed, or rotated. GitHub PR and push workflows now use the internal pip endpoint from build/package-feeds.json, while npm run ci:msft continues to use its internal npm default. CodeQL now sets both internal endpoints explicitly. Template/localization pins, platform matrices, Node/Python versions, packaging and publishing settings are unchanged. GitHub Actions feed authentication is not provisioned by this change; accessing internal feeds requires existing credentials.
Verification
No new Azure build was queued. The earlier validation run was canceled at the user's request with
publishExtension: false. Local authentication tests verify credential use, not real internal-feed authorization. Auto-merge remains disabled; these changes require review.