Repository navigation
Use shared localization tooling from vscode-python-ci - #2010
Merged
Merged
Conversation
Pin GitHub localization and stable/pre-release Azure tooling to the same reviewed shared-action merge while preserving caller configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
Contributor
|
🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman CLI is not installed or is not on PATH. Test runs: none recorded. |
Stella Huang (StellaHuang95)
approved these changes
Nov 11, 2026
Stella Huang (StellaHuang95)
left a comment
Stella Huang (StellaHuang95)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Stella Huang (StellaHuang95)
added
the
review-auto:approved
Eduardo Villalpando Mello (edvilme)
added
the
no-merge
Contributor
Author
|
Added no-merge tag. This should be merged after today's release |
Rich Chiodo (rchiodo)
approved these changes
Nov 11, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Merged
4 tasks
Eduardo Villalpando Mello (edvilme)
added a commit
to microsoft/vscode-common-python-lsp
that referenced
this pull request
Nov 12, 2026
## Summary Retire the duplicated localization automation now maintained in [microsoft/vscode-python-ci](https://github.com/microsoft/vscode-python-ci/tree/main/actions/localization). - Remove `.github/actions/localization/action.yml`, `scripts/localization.py`, and its regression tests. - Remove only the corresponding localization test/lint commands from nox; preserve all runtime package commands. - Remove the README's Shared localization automation section; shared tooling PRs [#14](microsoft/vscode-python-ci#14) and [#15](microsoft/vscode-python-ci#15) are merged. No Python/TypeScript runtime libraries, source strings, package versions, credentials, translation data, or release settings change. Existing callers pinned to historical commits remain usable; this PR does not delete tags or rewrite history. New callers must use `microsoft/vscode-python-ci/actions/localization`, and Azure tooling checkouts must use that repository with the unchanged `scripts/localization.py` interface. ## Validation - Existing Python runtime tests: **333 passed, 2 skipped**. - Black, Flake8, and isort checks passed for `noxfile.py`. - Nox session discovery and version synchronization passed. - Recorded each nox session's commands against `origin/main`: all non-localization install/test/lint commands are unchanged. - Removed paths and `git diff --check` verified. - Earlier rollout validation: two successful GitHub localization runs each for Black, Flake8, isort, Mypy, Pylint, autopep8, and the Python Environments migration branch. These were synchronized no-ops, not changed-string submissions. ## Draft / merge readiness This PR intentionally remains a draft. The default-branch GitHub caller audit still finds: - [ ] Merge [Python Environments #2010](microsoft/vscode-python-environments#2010); its `main` workflow still uses the old action. - [ ] Merge [Python Debugger #1143](microsoft/vscode-python-debugger#1143), migrating its GitHub action and stable/pre-release Azure tooling references. - [ ] Complete safe, non-publishing Azure localization import/package validation, including service-connection access to `vscode-python-ci`. GitHub tag/release creation must also be disabled; `publishExtension: false` alone is not sufficient evidence. - [ ] Review remaining Azure/release-branch/unpinned consumers before marking ready. The default-branch GitHub search is not an exhaustive audit of every caller. The two confirmed remaining workflows pin the historical `6b4a3573e7e7a9fe1e468e129544432278aec2d6` revision, so deleting the action on the new main revision does not immediately break those pinned workflows. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
Eduardo Villalpando Mello (edvilme)
removed
the
no-merge
Eduardo Villalpando Mello (edvilme)
merged commit Nov 13, 2026
a32fb10
into
main
123 of 125 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow the successful Black Formatter pilot: microsoft/vscode-black-formatter#844 and https://github.com/microsoft/vscode-black-formatter/actions/runs/43083946783.
microsoft/vscode-python-ci/actions/localization@f078b68e968b56e0a22d6cf803bb241a6b094994for English submission.localizationToolsin stable and pre-release Azure definitions to the same repository and SHA.The shared helper remains at
scripts/localization.py. No Azure-template rewrite, package/version change, dependency change or release is included. Existing App ID/private key stay in the caller; no credential migration is needed. The implementation was merged in microsoft/vscode-python-ci#14.Validation
Follow-up validation
Github-Pylancecan read the pinnedvscode-python-cirepository.Black's GitHub result does not prove Azure packaging or this caller's live credentials. No live localization submission or Azure release has been queued by this PR.
Rollback
Restore the action to
microsoft/vscode-common-python-lsp/.github/actions/localization@6b4a3573e7e7a9fe1e468e129544432278aec2d6and bothlocalizationToolsresources tomicrosoft/vscode-common-python-lsp@6b4a3573e7e7a9fe1e468e129544432278aec2d6together. Old tooling is retained.