Repository navigation
Select existing environment before creating template project - #2012
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Stella Huang (StellaHuang95)
added
the
feature-request
| : overrides.findIndex( | ||
| (s) => | ||
| !s.workspace && normalizePath(path.resolve(w.uri.fsPath, s.path)) === pwPath, | ||
| ); |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
If a multi-root workspace folder is renamed, its existing setting retains the old workspace qualifier. Neither branch removes that entry, while project loading can still fall back to the matching path; removing the project then leaves it persisted and it reappears after reload. Please preserve the loader's orphaned-qualifier fallback here without removing an entry owned by another live root, and add a renamed-folder regression test.
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bill Schnurr (bschnurr)
left a comment
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
Validation
npm run lintnpm run compile-testsnpm run unittest(3,546 passing, 9 pending)npm run compileFixes #518