Repository navigation
Show discovered projects in the add-project quick pick - #2022
Open
Mohammad Malik (mohammad-malik) wants to merge 1 commit into
Open
Mohammad Malik (mohammad-malik) wants to merge 1 commit into
Mohammad Malik (mohammad-malik) wants to merge 1 commit into
Conversation
Search for pyproject.toml and setup.py before the picker opens, and list the projects that are not already registered. Add all of them from that same list when more than one is found. Leave Auto Find out when the search would find nothing, so it cannot end in a "No projects found" error. Co-authored-by: Mohammad Malik <mohammad-malik@users.noreply.github.com>
|
Mohammad Malik (@mohammad-malik) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479
Summary
The add-project quick pick used to run discovery only after Auto Find was chosen. When the workspace had nothing new to add, that choice ended in a "No projects found" error.
The extension now searches for
pyproject.tomlandsetup.pybefore the quick pick opens. Folders that are not already projects are items in that same list, next to Select Existing and Create New. Choosing one adds that project. When more than one is found, Add all discovered projects adds every listed folder. If the search finds nothing new, Auto Find is not offered, so it cannot end in that error.That puts discovery in the quick pick from the issue. Hiding Auto Find when nothing would be found is the empty result of the same search, instead of a separate action that fails.
Choosing an arbitrary subset is no longer a second multi-select step. Add one project, add all of them, or open the picker again.
How tested
.venv, thennpm installnpm run lintnpm run compile-testsandnpm run unittest(3575 passing, 12 pending)npm run compileNote
Low Risk
Changes are limited to add-project UI and project registration, with broad unit test coverage and no auth or data-handling impact.
Reviewed by Cursor Bugbot for commit d5d5c26. Bugbot is set up for automated code reviews on this repo. Configure here.