Repository navigation
Retain Windows integration-test failure diagnostics - #2025
Merged
Stella Huang (StellaHuang95) merged 1 commit intoNov 13, 2026
Conversation
Capture launcher output and existing VS Code diagnostics for failed Windows integration runs without changing the test command or non-Windows behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Nov 13, 2026
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Stella Huang (StellaHuang95)
merged commit Nov 13, 2026
c7c4a7a
into
microsoft:main
62 of 64 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run integration-testbehavior unchanged.npm run integration-testcommand under PowerShell, with stdout/stderr tee'd tolauncher.logand its exit code explicitly preserved.VSCODE_TEST_DIAGNOSTICS_DIRhook in a short directory underRUNNER_TEMPto retain VS Code logs and the test-runner startup marker.if-no-files-found: errorconvention.The only changed file is
.github/workflows/pr-check.yml. This is one fresh commit based on upstreammainatb3e545565f019d70cd77ee17c21dd050a812b34d; no production or test files were changed.Context
The Windows Python 3.12 failure in run 43312721437 and Python 3.14 failure in run 43312697435 both reported that the workspace
.venvremained after API removal. Their retained artifacts contained the VSIX, not removal/validation output logs. The underlying filesystem error and any lock holder remain unknown.This PR adds failure diagnostics; it does not claim to fix the original flake. It does not change deletion behavior, assertions, timeouts, sleeps, or Mocha retries.
Validation
npm run compilepassed.launcher.log,test-runner-started.json, and 32 VS Code log files, including the Python Environments output-channel log.