Skip to content

Retain Windows integration-test failure diagnostics - #2025

Merged
Stella Huang (StellaHuang95) merged 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang-microsoft-windows-ci-diagnostics
Nov 13, 2026
Merged

Stella Huang (StellaHuang95) merged 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang-microsoft-windows-ci-diagnostics

Conversation

@StellaHuang95

Copy link
Copy Markdown
Contributor

Summary

  • Keep the Linux integration-test action and macOS npm run integration-test behavior unchanged.
  • Run the same Windows npm run integration-test command under PowerShell, with stdout/stderr tee'd to launcher.log and its exit code explicitly preserved.
  • Enable the existing VSCODE_TEST_DIAGNOSTICS_DIR hook in a short directory under RUNNER_TEMP to retain VS Code logs and the test-runner startup marker.
  • Upload that directory only when the Windows integration-test step fails, reusing the pinned upload-artifact action, seven-day retention, and if-no-files-found: error convention.

The only changed file is .github/workflows/pr-check.yml. This is one fresh commit based on upstream main at b3e545565f019d70cd77ee17c21dd050a812b34d; no production or test files were changed.

Context

The Windows Python 3.12 failure in run 43312721437 and Python 3.14 failure in run 43312697435 both reported that the workspace .venv remained after API removal. Their retained artifacts contained the VSIX, not removal/validation output logs. The underlying filesystem error and any lock holder remain unknown.

This PR adds failure diagnostics; it does not claim to fix the original flake. It does not change deletion behavior, assertions, timeouts, sleeps, or Mocha retries.

Validation

  • Mandatory pre-commit lint and TypeScript checks passed; the full unit suite passed with 3,573 passing and 9 pending tests.
  • npm run compile passed.
  • actionlint 1.7.12, parsed workflow invariants, and PowerShell syntax validation passed. All other jobs and the original Linux/macOS behavior match upstream exactly.
  • The existing diagnostics hook was checked both unset and enabled.
  • One existing read-only integration test passed in real VS Code 1.146.0, generating launcher.log, test-runner-started.json, and 32 VS Code log files, including the Python Environments output-channel log.
  • PowerShell stdout/stderr probes preserved exit statuses 0 and 7, and an actual Windows npm-shim error preserved exit 1 and its stderr through Tee-Object.

Capture launcher output and existing VS Code diagnostics for failed Windows integration runs without changing the test command or non-Windows behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rchiodo

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown
Contributor

Reviewed commit: 939366268d35e6a8efd8abb5b15c8b3aedf5102a

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine &#x27;pyrx-automation&#x27; is not running.

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 13, 2026
@StellaHuang95
Stella Huang (StellaHuang95) merged commit c7c4a7a into microsoft:main Nov 13, 2026
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues no-changelog review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants