Repository navigation
Add DevDiv API and static analysis pipelines - #26288
Stella Huang (StellaHuang95) merged 6 commits into
Conversation
b3fa84c to
847764e
Compare
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "f4038dbd007f034ebb49a5783a29e05774abe96d112a0f00a72ab8915a10a2a9": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
6967f96 to
642c63b
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
642c63b to
7c8326b
Compare
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
e66d450
into
microsoft:main
Summary
build/azure-pipelines/devdiv/python-extension-api.ymlfor the@vscode/python-extensionpackagelatest/next; publication disabled by default; API Scan; TSA; secure ESRP npm publication; DevDiv feed publication; andrelease/pythonExtensionApi/GitHub releases/tagsbuild/azure-pipelines/devdiv/static-analysis.ymlas the source-controlled replacement for classic definition 13577pythonFilestopython_filesand making AntiMalware scan the source treeDesign notes
The API pipeline follows the proven DevDiv MicroBuild/1ES npm pattern. API Scan and TSA remain explicit jobs/tasks to avoid duplicate 1ES injection. The Monaco symbol feed was removed; API Scan uses SymWeb and the extracted package only. The existing API pipeline TSA notification alias
monacotools@microsoft.comis retained because there is no verified Python team alias in the repository; the owning team should confirm a replacement before cutover.The static pipeline is YAML because DevDiv reports that new classic pipelines are disabled for the project/organization. Its
sdlblock explicitly disables auto-injected Bandit, AntiMalware, component governance, CredScan, ESLint, PoliCheck, report/log, and TSA tasks so only the parity-preserving legacy tasks run. Static TSA retains 13577'skanadig@microsoft.comnotification alias pending an approved Python-team alias. It adds service tree ID6e6194bc-7baa-4486-86d0-9f5419626d46, which is already used by the vscode-python extension pipelines; 13577 left this value empty. Definition 13577 is not modified or disabled.Validation
git diff --checkpassesTests (ubuntu-latest, 3.x, venv)failed twice before tests because the existing workflow had a nullCONDAenvironment variable atJoin-Path -Path $Env:CONDA; this is unrelated to the two YAML-only changes. The external vscode-engineering run completed successfully even though GitHub's aggregate check remains stale/pending.Pylance_PublicPackagesfeed exist in DevDivAccess denied. Stella Huang needs Create build pipeline permissions for path \Python\VSCode Python Extensions\vscode-python in team project DevDiv to perform the action.The same denial occurs at\PythonUser not permitted to queue dry run for build pipeline 27973 with modified YAML. Permissions needed: EditBuild.vscode-apiscanand a secretAPIScanConnectionStringpipeline variable; neither is currently visible to the callerAn admin can unblock validation by granting Create build pipeline on
\Python\VSCode Python Extensions\vscode-python, or by granting EditBuild on a validation definition foryamlOverride. After that:refs/pull/26288/mergewith GitHub connectionfb1b4583-c76e-4376-b5a0-294d56ae7d09.quality=latest publishPythonApi=false runAPIScan=falseto validate build, tests, and package creation before API Scan credentials are provisioned.vscode-apiscanplus the secretAPIScanConnectionString, then rerun withquality=latest publishPythonApi=false runAPIScan=true.The pipeline guard prevents publication when API Scan is disabled. Existing definitions 635 and 13577 must remain untouched until both replacements succeed.
Tracking: https://github.com/microsoft/pyrx/issues/10073