Skip to content

Make venv CI independent of the runner Conda environment #26290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits into from
Nov 13, 2026
Merged

Make venv CI independent of the runner Conda environment #26290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324eab5
Initial plan
Copilot Nov 12, 2026
335f651
Fix Conda setup for venv CI jobs
Copilot Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ jobs:
& "./.venv/bin/python" ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} venvPath
}

- name: Set up Conda for venv tests
uses: conda-incubator/setup-miniconda@be893c923ea9cf1cf7cd510fbdde27c7e18cbdcb # v4.1.0
with:
activate-environment: ''
auto-activate: false
if: matrix.test-suite == 'venv'

- name: Prepare conda for venv tests
env:
TEST_FILES_SUFFIX: testvirtualenvs
Expand All @@ -343,12 +350,23 @@ jobs:
if: matrix.test-suite == 'venv'
run: |
# 1. For `*.testvirtualenvs.test.ts`
$condaCommand = Get-Command conda -CommandType Application -ErrorAction SilentlyContinue | Select-Object -First 1
if (-not $condaCommand) {
throw 'Conda executable was not found on PATH.'
}
$condaExecPath = $condaCommand.Source
$condaBasePath = & $condaExecPath info --base
if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($condaBasePath)) {
throw "Could not determine the Conda base directory using '$condaExecPath info --base'."
}
$condaBasePath = "$condaBasePath".Trim()
if ('${{ matrix.os }}' -match 'windows-latest') {
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath python.exe
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath Scripts | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath python.exe
} else{
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath python
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath bin | Join-Path -ChildPath python
}
if (-not (Test-Path -Path $condaPythonPath -PathType Leaf)) {
throw "Conda base Python was not found at '$condaPythonPath'."
}
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaExecPath $condaExecPath
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaPath
Expand Down
51 changes: 43 additions & 8 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,13 @@ jobs:
& "./.venv/bin/python" ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} venvPath
}

- name: Set up Conda for venv tests
uses: conda-incubator/setup-miniconda@be893c923ea9cf1cf7cd510fbdde27c7e18cbdcb # v4.1.0
with:
activate-environment: ''
auto-activate: false
if: matrix.test-suite == 'venv'

- name: Prepare conda for venv tests
env:
TEST_FILES_SUFFIX: testvirtualenvs
Expand All @@ -336,12 +343,23 @@ jobs:
if: matrix.test-suite == 'venv'
run: |
# 1. For `*.testvirtualenvs.test.ts`
$condaCommand = Get-Command conda -CommandType Application -ErrorAction SilentlyContinue | Select-Object -First 1
if (-not $condaCommand) {
throw 'Conda executable was not found on PATH.'
}
$condaExecPath = $condaCommand.Source
$condaBasePath = & $condaExecPath info --base
if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($condaBasePath)) {
throw "Could not determine the Conda base directory using '$condaExecPath info --base'."
}
$condaBasePath = "$condaBasePath".Trim()
if ('${{ matrix.os }}' -match 'windows-latest') {
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath python.exe
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath Scripts | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath python.exe
} else{
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath python
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath bin | Join-Path -ChildPath python
}
if (-not (Test-Path -Path $condaPythonPath -PathType Leaf)) {
throw "Conda base Python was not found at '$condaPythonPath'."
}
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaExecPath $condaExecPath
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaPath
Expand Down Expand Up @@ -610,19 +628,36 @@ jobs:
& "./.venv/bin/python" ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} venvPath
}

- name: Set up Conda for venv tests
uses: conda-incubator/setup-miniconda@be893c923ea9cf1cf7cd510fbdde27c7e18cbdcb # v4.1.0
with:
activate-environment: ''
auto-activate: false

- name: Prepare conda for venv tests
env:
TEST_FILES_SUFFIX: testvirtualenvs
PYTHON_VIRTUAL_ENVS_LOCATION: './src/tmp/envPaths.json'
shell: pwsh
run: |
# 1. For `*.testvirtualenvs.test.ts`
$condaCommand = Get-Command conda -CommandType Application -ErrorAction SilentlyContinue | Select-Object -First 1
if (-not $condaCommand) {
throw 'Conda executable was not found on PATH.'
}
$condaExecPath = $condaCommand.Source
$condaBasePath = & $condaExecPath info --base
if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($condaBasePath)) {
throw "Could not determine the Conda base directory using '$condaExecPath info --base'."
}
$condaBasePath = "$condaBasePath".Trim()
if ('${{ matrix.os }}' -match 'windows-latest') {
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath python.exe
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath Scripts | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath python.exe
} else{
$condaPythonPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath python
$condaExecPath = Join-Path -Path $Env:CONDA -ChildPath bin | Join-Path -ChildPath conda
$condaPythonPath = Join-Path -Path $condaBasePath -ChildPath bin | Join-Path -ChildPath python
}
if (-not (Test-Path -Path $condaPythonPath -PathType Leaf)) {
throw "Conda base Python was not found at '$condaPythonPath'."
}
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaExecPath $condaExecPath
& $condaPythonPath ./build/ci/addEnvPath.py ${{ env.PYTHON_VIRTUAL_ENVS_LOCATION }} condaPath
Expand Down
Loading