Repository navigation
build: migrate from tsc to tsdown - #395
Merged
Merged
Conversation
Build every package with tsdown from one shared root tsdown.config.ts. Each package's prepack runs `tsdown`, which finds the root config; entries come from the package's exports. unbundle keeps one output file per source module, as tsc did, and packages stay external. - Generate declarations with oxc. - Fail the build when dist imports a package that isn't in the package's dependencies or peerDependencies (deps.onlyImport). - Switch the root tsconfig to module preserve with bundler resolution and drop the .ts extension from relative imports. - Remove the tsc-only tsconfig.lib.json options. - Bump oxlint, oxlint-tsgolint and oxfmt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VVaw7RpPRpasxuSAB8fbND
|
Important Review skippedToo many files! This PR contains 113 files, which is 13 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance
Comparing 
Footnotes
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
tsdownreplaces per-packagetsc— every package'sprepackis nowtsdown, driven by one root config that derives entries from the package'sexports, keeps one module per file (unbundle), externalizes dependencies (neverBundle+onlyImport), and emits declarations with the oxc generator.- Module resolution moves to the bundler — the root tsconfig switches to
module: preserve+moduleResolution: bundler, and the.tssuffix is dropped from every relative import acrosssrc, tests, benches, and the generated OAI fixtures. - Emit-only tsconfig settings removed —
tsconfig.lib.jsonkeeps onlytypes: []now thattscno longer emits, whiletsdownand the oxlint/oxfmt bumps land in the root manifest and lockfile.
I verified the migration locally: all three prepack builds, pnpm check, the full 377-test suite, and sherif pass; the packed tarballs carry the expected publishConfig entries and runtime modules; a scratch consumer type-checks against them under both nodenext and bundler with skipLibCheck: false; and exported names plus public JSDoc blocks/tags match between source and emitted declarations.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
dinwwwh
added a commit
to middleapi/orpc
that referenced
this pull request
Nov 9, 2026
## Why Builds move from per-package `tsc` to tsdown, driven by one shared config at the root. Output keeps tsc's shape (one `.js` and `.d.ts` per source module), so `publishConfig.exports` and `sideEffects` stay as they are. Same migration as middleapi/standard-server#188 and middleapi/openapi-spec#395, which use a simpler config. ## Changes - **One root `tsdown.config.ts`.** tsdown finds it from each package directory, so every `prepack` is just `tsdown`. Entries come from each package's `exports`. `unbundle` keeps one file per module; relative imports like `../package.json` are still bundled in (`@orpc/opentelemetry` inlines only `name` and `version`), and packages stay external. - **Declarations come from oxc** (`dts: { generator: 'oxc' }`). The tsgo generator drops the `DecoratedProcedure` import from `@orpc/effect`'s `extensions/effect.d.ts`, because it is used only inside a `declare module '@orpc/server'` augmentation. That is the bug reported in #2446 (comment 19474307). oxc needs explicit types on exports. Only `@orpc/shared`'s regex constants lacked them; a missing annotation now fails the build. - **Re-exports stay tree-shakeable.** Rolldown writes re-exports as `import { a } from 'x'; export { a }`, which Expo's tree shaking can't see through (the problem behind #2362). A small `renderChunk` hook in the config turns them back into `export { a } from 'x'`, in the import's position so evaluation order is unchanged. tsdown and rolldown have no option for this. - **Undeclared imports fail the build.** `deps.onlyImport` lists each package's `dependencies` and `peerDependencies` plus the runtime modules (`bun`, `bun:*`, `node:*`, `cloudflare:*`). Any `.js` or `.d.ts` in `dist` that imports something else fails the build, including CommonJS-only packages and type-only imports. - **Runtime modules are marked external** through rolldown's `external` option, using the same list. `neverBundle: true` keeps Node built-ins and npm-style names as written, but other `prefix:` modules (e.g. `cloudflare:workers`) fall through to resolution and warn that they can't be resolved. - **Bundler module resolution.** The root tsconfig uses `module: preserve` with `moduleResolution: bundler`, and the `.ts`/`.tsx` extension is dropped from relative imports across packages, tests, benches and the docs site. `dist` still imports with `.js` extensions. `verbatimModuleSyntax` stays: without it `pnpm check` misses type-only re-exports, which then only fail at build time. - **Cleanup and bumps.** The emit-only options in `tsconfig.lib.json` and the bun/cloudflare/nest `tsconfig.build.json` files are gone. oxlint, oxlint-tsgolint, oxfmt and `@orpc/nest`'s `@oxc-project/runtime` are bumped. - **JSDoc kept under oxc.** `ORPCModule` is written as `export @module({}) class`, since oxc drops a class's JSDoc that sits above its decorators. `TmpFile.path` is now a documented field rather than a documented constructor parameter. ## Verification - `pnpm check`, `pnpm test` and `pnpm docs:validate` pass, and all 29 packages build without warnings. - Every relative import in `dist` resolves, and every `publishConfig.exports` and `sideEffects` path exists. - The emitted declarations type-check for a `nodenext` consumer with `skipLibCheck: false`. - **#2446 reproduction**, built against `dist`: with tsgo declarations, a missing required context and a wrong input type both compile. With oxc both are rejected, matching the source types. - **Declaration diff, tsgo vs oxc:** the same 312 files, 295 identical apart from formatting. The rest differ only in kept `override` modifiers, quoted member names, and three file-level comments in `json-schema` that aren't attached to any declaration. - **Re-export hook:** it rewrites 44 of 309 `.js` files and no `.d.ts`. Loading each rewritten file in Node gives the same export names and value types as a build without the hook. - **`onlyImport`:** adding an undeclared `valibot` (runtime and type-only) or `change-case` import to `@orpc/zod` fails the build with `… is imported in index.js but is not included in deps.onlyImport option`. A `bun:sqlite` import in `@orpc/bun` builds cleanly and stays an import. - **Expo SDK 58** (Android export, `EXPO_UNSTABLE_TREE_SHAKING=1`), importing only `OpenAPILink` and the client: | Build | Bundle | Server-only markers | |---|---|---| | tsc (beta.49) | 1,024,626 B | 0/12 | | tsdown, no hook | 1,109,354 B | 12/12 | | this PR | 1,027,558 B | 0/12 | ## Behavior changes - `dist` no longer contains empty `.js` files for type-only modules, nor `.d.ts` files that no public type refers to (for example `router-hidden.d.ts`). Nothing imports them. - Declarations no longer contain non-JSDoc comments. - `@orpc/nest` bundles its decorator helpers under `dist/_virtual/_@oxc-project_runtime@0.157.0/…`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VVaw7RpPRpasxuSAB8fbND Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Builds move from per-package
tscto tsdown with one shared root config, the same migration as middleapi/orpc#2448 in a simpler form. This repo needs neither oRPC's re-export hook for Expo tree shaking nor its runtime-module list. Output keeps tsc's shape (one.jsand.d.tsper source module), sopublishConfig.exportsstays as it is.Changes
tsdown.config.ts. tsdown finds it from each package directory, so everyprepackis justtsdown. Entries come from each package'sexports;unbundlekeeps one file per module, and packages stay external (neverBundle: true).dts: { generator: 'oxc' }), which needs explicit types on exports. All sources already had them, and a missing one now fails the build.deps.onlyImportlists each package'sdependenciesandpeerDependencies.srchas nonode:imports, so the platform staysneutral.module: preservewithmoduleResolution: bundler, and the.tsextension is dropped from relative imports in packages.diststill imports with.jsextensions.verbatimModuleSyntaxstays: without itpnpm checkmisses type-only re-exports, which then only fail at build time.tsconfig.lib.jsonare gone; oxlint, oxlint-tsgolint and oxfmt are bumped.Verification
pnpm check,pnpm test(377 tests) and all 3 package builds pass without warnings.nodenextconsumer withskipLibCheck: falseandexactOptionalPropertyTypes.Behavior changes
@openapi-spec/downgraderno longer shipsdist/shared.d.ts, which no public type refers to.Generated by Claude Code