Repository navigation
ci: publish.yml without --workspace-concurrency, which pnpm publish refuses - #252
Merged
Merged
Conversation
…efuses (#251) The first run stopped on the unknown option before publishing anything. A recursive publish already goes one package at a time, in dependency order.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251.
The first run of
publish.ymlfailed before publishing anything, onERROR Unknown option: 'workspace-concurrency'.pnpm publishdoes not take that option.What changes
publish.ymlrunspnpm -r publish --access public --no-git-checks, plus--dry-runwhen asked. It still publishes one package at a time, in dependency order. pnpm 10.24's recursive publish does that by itself: it walks the sorted chunks and awaits each package's publish. The comment says so, and why the option went.Tested
--filter @missing-elements/h5p-libraries --dry-runadded, the same command parses and packs@missing-elements/h5p-libraries@1.1.1(156 files), then stops at "Publishing to https://registry.npmjs.org/ with tag latest and public access (dry-run)".After the merge, run
gh workflow run publish.yml -R missing-elements/h5p-toolkitagain, before 2026-11-21 13:19 UTC.Summary by cubic
Fixes the
publish.ymlworkflow so it no longer passes--workspace-concurrencytopnpm publish, which pnpm rejects and caused the first run to fail before publishing anything. Recursive publish already processes packages one at a time in dependency order, so the flag was unnecessary.Written for commit 801ab79. Summary will update on new commits.