Skip to content

ci: publish.yml without --workspace-concurrency, which pnpm publish refuses - #252

Merged
alekswebnet merged 1 commit into
mainfrom
fix/publish-workflow-flag
Nov 19, 2026
Merged

alekswebnet merged 1 commit into
mainfrom
fix/publish-workflow-flag

Conversation

@alekswebnet

@alekswebnet alekswebnet commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #251.

The first run of publish.yml failed before publishing anything, on ERROR Unknown option: 'workspace-concurrency'. pnpm publish does not take that option.

What changes

publish.yml runs pnpm -r publish --access public --no-git-checks, plus --dry-run when asked. It still publishes one package at a time, in dependency order. pnpm 10.24's recursive publish does that by itself: it walks the sorted chunks and awaits each package's publish. The comment says so, and why the option went.

Tested

  • The command: with --filter @missing-elements/h5p-libraries --dry-run added, the same command parses and packs @missing-elements/h5p-libraries@1.1.1 (156 files), then stops at "Publishing to https://registry.npmjs.org/ with tag latest and public access (dry-run)".
  • The workflow file: it parses as YAML.

After the merge, run gh workflow run publish.yml -R missing-elements/h5p-toolkit again, before 2026-11-21 13:19 UTC.


Summary by cubic

Fixes the publish.yml workflow so it no longer passes --workspace-concurrency to pnpm publish, which pnpm rejects and caused the first run to fail before publishing anything. Recursive publish already processes packages one at a time in dependency order, so the flag was unnecessary.

Written for commit 801ab79. Summary will update on new commits.

View guided diff Turn on auto-fix

…efuses (#251)

The first run stopped on the unknown option before publishing anything. A
recursive publish already goes one package at a time, in dependency order.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/publish.yml Resolved
@alekswebnet
alekswebnet merged commit ae1c711 into main Nov 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish.yml: pnpm publish refuses --workspace-concurrency

1 participant