Repository navigation
fix: Preserve standalone named expression parentheses - #488
Merged
pawamoy merged 3 commits intoOct 16, 2026
Merged
Conversation
Member
|
Follow-up of #480. |
lprnmns
marked this pull request as ready for review
September 3, 2026 10:58
pawamoy
force-pushed
the
codex/fix-standalone-walrus-parentheses
branch
from
October 16, 2026 16:20
bef6f7e to
0f75dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
Preserve the required parentheses when a named expression is rendered on its own. Previously,
(value := 1)becamevalue := 1, which cannot be parsed as an expression.Nested named expressions keep using the existing context-aware renderer, so their output is unchanged.
Relevant resources
mainbranch.PYTHON_VERSIONS='' ./scripts/make check test.venv/bin/python -m pytest packages/griffelib/tests/test_expressions.py -q— 918 passed, 16 skipped