Skip to content

Hold bracket exits until entry and price resting limit gaps - #196

Draft
stefan-jansen wants to merge 5 commits into
mainfrom
fix/conditional-execution-183-193
Draft

stefan-jansen wants to merge 5 commits into
mainfrom
fix/conditional-execution-183-193

Conversation

@stefan-jansen

Copy link
Copy Markdown
Contributor

Fixes #193. Addresses the favorable-opening-gap case in #183.

Hold bracket exits until the observation after the complete entry fill, and cancel the exits if the entry is cancelled or rejected. For a resting OHLC limit, use an observed favorable open; after-open submissions cannot reuse it. Intrabar touches still use the limit as the starting price, and final execution still cannot violate that limit.

All 14 new public engine cases fail on the previous behavior. The 90 focused order tests, Ruff and type checking pass. Draft pending final qualification and comparison evidence for the new runtime.

AI assistance: Codex reproduced the defects, prepared the code and documentation, and ran the listed checks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bracket legs can fill before their entry when the trigger is met on the entry bar

1 participant