Repository navigation
Hold bracket exits until entry and price resting limit gaps - #196
Draft
stefan-jansen wants to merge 5 commits into
Draft
stefan-jansen wants to merge 5 commits into
stefan-jansen wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193. Addresses the favorable-opening-gap case in #183.
Hold bracket exits until the observation after the complete entry fill, and cancel the exits if the entry is cancelled or rejected. For a resting OHLC limit, use an observed favorable open; after-open submissions cannot reuse it. Intrabar touches still use the limit as the starting price, and final execution still cannot violate that limit.
All 14 new public engine cases fail on the previous behavior. The 90 focused order tests, Ruff and type checking pass. Draft pending final qualification and comparison evidence for the new runtime.
AI assistance: Codex reproduced the defects, prepared the code and documentation, and ran the listed checks.