Skip to content

Brief refactoring in response to Copilot/Claude code review - #83

Merged
rshiggin merged 2 commits into
mainfrom
arc-170-repo-id-requestable-bug-refactor
Aug 27, 2026
Merged

Brief refactoring in response to Copilot/Claude code review#83
rshiggin merged 2 commits into
mainfrom
arc-170-repo-id-requestable-bug-refactor

Conversation

@rshiggin

@rshiggin rshiggin commented Aug 25, 2026

Copy link
Copy Markdown
Member

@rshiggin
rshiggin marked this pull request as ready for review August 25, 2026 20:45
@rshiggin
rshiggin requested a review from ssciolla August 25, 2026 20:45

@ssciolla ssciolla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mildly suggesting that we use a more specific error type.

Comment thread lib/um_arclight/traject/ead2_config.rb Outdated
@rshiggin
rshiggin force-pushed the arc-170-repo-id-requestable-bug-refactor branch from bdfae25 to 130d0ca Compare August 27, 2026 18:26
@rshiggin
rshiggin merged commit 2242422 into main Aug 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants