Repository navigation
windows: rewrite some code with golang.org/x/sys/windows - #62
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The API migration preserves behavior and correctly handles unsuccessful or unexpected wait results.
Review effort: Balanced
Findings: None
What changed in this PR
Replaces the custom Windows wait wrapper with golang.org/x/sys/windows.
Changes:
- Uses
windows.WaitForSingleObjectwith explicit result validation. - Simplifies console input reading error handling.
| File | Description |
|---|---|
windows/ansi_reader.go |
Migrates waiting logic to x/sys/windows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.