-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Apply the request body limit to the SSE and OAuth endpoints #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxisbey
wants to merge
3
commits into
main
Choose a base branch
from
request-body-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new OAuth request-body limit only guards POST, but the wrapped routes accept other methods whose handlers still read the full body — so the 413 protection is bypassed by switching the method.
RequestBodyLimitMiddleware.__call__passes any non-POST request straight through (src/mcp/server/streamable_http_manager.py:382if scope["type"] != "http" or scope["method"] != "POST"), and_body_limitedrelies on it. Yet/token,/register, and/revokeare registered withmethods=["POST", "OPTIONS"], and a plain OPTIONS request without anOriginheader (or withoutAccess-Control-Request-Method) is not a CORS preflight, soCORSMiddlewareforwards it to the handler. All three handlers read the body unconditionally:RegistrationHandler.handlecalls `await…Extended reasoning...
An unauthenticated attacker sends
OPTIONS /registerwith no Origin header,Content-Type: application/json, and a multi-gigabyte (e.g. chunked) body. CORSMiddleware passes it through (not a preflight), the Route allows OPTIONS, RequestBodyLimitMiddleware skips it because the method is not POST, andRegistrationHandler.handleexecutesawait request.body(), buffering the entire attacker-controlled body in server memory. The same works on/tokenand/revokewithContent-Type: application/x-www-form-urlencoded(Starlette'sform()reads the whole body into memory), and on/authorizevia HEAD. The 4 MiB cap this PR advertises for the OAuth endpoints (test: "rejects one over 4 MiB before parsing it") is therefore trivially bypassed, allowing memory-exhaustion DoS against the authorization server.Verification: normal — the bypass is real: the guard this PR adds is method-gated to POST while the wrapped routes accept other methods whose handlers read the body unconditionally. Chain of citations: 1. /home/claude/python-sdk/src/mcp/server/streamable_http_manager.py:382 —
if scope["type"] != "http" or scope["method"] != "POST": await self.app(scope, receive, send); return— RequestBodyLimitMiddlew