Skip to content

fix(filesystem): reject existing move destinations - #4706

Closed
CryoThrust wants to merge 2 commits into
modelcontextprotocol:mainfrom
CryoThrust:fix/filesystem-reject-existing-move-destination
Closed

fix(filesystem): reject existing move destinations#4706
CryoThrust wants to merge 2 commits into
modelcontextprotocol:mainfrom
CryoThrust:fix/filesystem-reject-existing-move-destination

Conversation

@CryoThrust

Copy link
Copy Markdown
Contributor

Summary

  • reject move_file when the destination already exists
  • avoid platform-dependent fs.rename overwrite behavior and potential data loss
  • add an integration regression test verifying both source and destination remain intact

Closes #4628

Validation

  • git diff --check
  • Vitest execution is currently blocked on this host because the Homebrew Node 22 binary cannot load libsimdjson.29.dylib.

@CryoThrust

Copy link
Copy Markdown
Contributor Author

Closing this PR because #4654 already covers the same move_file overwrite behavior. Keeping the upstream PR as the single implementation avoids duplicate work.

@CryoThrust CryoThrust closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server-filesystem: move_file silently overwrites an existing destination (data loss)

1 participant