Repository navigation
fix: quietly skip default Prometheus without client - #428
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
prometheus_clientis missing, the default metrics path now silently skips Prometheus as unconfigured. Custom paths still emit a missing-dependency warning. FastAPI also checks forprometheus_clientalongside its instrumentator dependency.Use each config's declared path default so FastStream stays opt-in and an explicitly configured FastStream path still warns. Document the defaults and the configured/skipped exception. An explicitly set
/metricson FastAPI, Litestar, or FastMCP remains indistinguishable from the default and skips silently without the client.Closes #398.
Validation
just test-ci: 611 passed, 100% coverage.just lint-ci: formatting, lint, and typechecking passed.just docs-build: strict build passed.